You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2019/12/29 09:23:48 UTC
[GitHub] [incubator-hudi] XuQianJin-Stars opened a new pull request #1152:
[HUDI-454] Redo hudi-cli log statements using SLF4J
XuQianJin-Stars opened a new pull request #1152: [HUDI-454] Redo hudi-cli log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1152
## What is the purpose of the pull request
Redo hudi-cli log statements using SLF4J.
## Brief change log
Modify AnnotationLocation checkstyle rule in checkstyle.xml
## Verify this pull request
Use existing tests to verify the original module.
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] cdmikechen commented on issue #1152: [HUDI-454]
Redo hudi-cli log statements using SLF4J
Posted by GitBox <gi...@apache.org>.
cdmikechen commented on issue #1152: [HUDI-454] Redo hudi-cli log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1152#issuecomment-569568443
I found that
```
ERROR StatusLogger No log4j2 configuration file found. Using default configuration: logging only errors to the console.
```
If there is only one single project changing log4j to slf4j, is there a problem of log class conflict?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] XuQianJin-Stars commented on a change in pull
request #1152: [HUDI-454] Redo hudi-cli log statements using SLF4J
Posted by GitBox <gi...@apache.org>.
XuQianJin-Stars commented on a change in pull request #1152: [HUDI-454] Redo hudi-cli log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1152#discussion_r361928359
##########
File path: hudi-cli/src/main/java/org/apache/hudi/cli/utils/InputStreamConsumer.java
##########
@@ -46,7 +47,7 @@ public void run() {
LOG.info(line);
}
} catch (IOException ioe) {
- LOG.severe(ioe.toString());
+ LOG.error(ioe.toString());
Review comment:
yes, you are right, The method `ToString()` can remove.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] XuQianJin-Stars closed pull request #1152:
[HUDI-454] Redo hudi-cli log statements using SLF4J
Posted by GitBox <gi...@apache.org>.
XuQianJin-Stars closed pull request #1152: [HUDI-454] Redo hudi-cli log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1152
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] cdmikechen edited a comment on issue #1152:
[HUDI-454] Redo hudi-cli log statements using SLF4J
Posted by GitBox <gi...@apache.org>.
cdmikechen edited a comment on issue #1152: [HUDI-454] Redo hudi-cli log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1152#issuecomment-569568443
I found that in https://api.travis-ci.org/v3/job/630558609/log.txt
```
ERROR StatusLogger No log4j2 configuration file found. Using default configuration: logging only errors to the console.
```
If there is only one single project changing log4j to slf4j, is there a problem of log class conflict?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] yanghua commented on a change in pull request
#1152: [HUDI-454] Redo hudi-cli log statements using SLF4J
Posted by GitBox <gi...@apache.org>.
yanghua commented on a change in pull request #1152: [HUDI-454] Redo hudi-cli log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1152#discussion_r361909710
##########
File path: hudi-cli/src/main/java/org/apache/hudi/cli/utils/InputStreamConsumer.java
##########
@@ -46,7 +47,7 @@ public void run() {
LOG.info(line);
}
} catch (IOException ioe) {
- LOG.severe(ioe.toString());
+ LOG.error(ioe.toString());
Review comment:
Can we simplify it with `LOG.error(ioe);`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] yanghua commented on a change in pull request
#1152: [HUDI-454] Redo hudi-cli log statements using SLF4J
Posted by GitBox <gi...@apache.org>.
yanghua commented on a change in pull request #1152: [HUDI-454] Redo hudi-cli log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1152#discussion_r361926941
##########
File path: hudi-cli/src/main/java/org/apache/hudi/cli/utils/InputStreamConsumer.java
##########
@@ -46,7 +47,7 @@ public void run() {
LOG.info(line);
}
} catch (IOException ioe) {
- LOG.severe(ioe.toString());
+ LOG.error(ioe.toString());
Review comment:
I have no doubt about `SEVERE -> ERROR`. What I mean is that can we remove ioe ~.toString()~?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] yanghua commented on issue #1152: [HUDI-454] Redo
hudi-cli log statements using SLF4J
Posted by GitBox <gi...@apache.org>.
yanghua commented on issue #1152: [HUDI-454] Redo hudi-cli log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1152#issuecomment-569571196
> I found that in https://api.travis-ci.org/v3/job/630558609/log.txt
>
> ```
> ERROR StatusLogger No log4j2 configuration file found. Using default configuration: logging only errors to the console.
> ```
>
> If there is only one single project changing log4j to slf4j, is there a problem of log class conflict?
Maybe they are irrelevant? I fond another green PR which also contains this message in its log file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] yanghua commented on a change in pull request
#1152: [HUDI-454] Redo hudi-cli log statements using SLF4J
Posted by GitBox <gi...@apache.org>.
yanghua commented on a change in pull request #1152: [HUDI-454] Redo hudi-cli log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1152#discussion_r361909170
##########
File path: pom.xml
##########
@@ -96,6 +96,7 @@
<jetty.version>7.6.0.v20120127</jetty.version>
<hbase.version>1.2.3</hbase.version>
<codehaus-jackson.version>1.9.13</codehaus-jackson.version>
+ <slf4j.version>1.7.30</slf4j.version>
Review comment:
There should be a property definition of `slf4j.version` in Line 82.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] yanghua commented on issue #1152: [HUDI-454] Redo
hudi-cli log statements using SLF4J
Posted by GitBox <gi...@apache.org>.
yanghua commented on issue #1152: [HUDI-454] Redo hudi-cli log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1152#issuecomment-569565395
Hi @XuQianJin-Stars Found check style errors, the detailed log file is here: https://api.travis-ci.org/v3/job/630558609/log.txt
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] leesf commented on issue #1152: [HUDI-454] Redo
hudi-cli log statements using SLF4J
Posted by GitBox <gi...@apache.org>.
leesf commented on issue #1152: [HUDI-454] Redo hudi-cli log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1152#issuecomment-570736785
@XuQianJin-Stars Thanks for opening this PR, Could you please reopen and merge this PR to redo-log branch? more context can be found https://lists.apache.org/thread.html/9dc1f3a590413a5224a1a5ad835353e11b2b754e1ec7ad1ca0a55053%40%3Cdev.hudi.apache.org%3E, Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] cdmikechen commented on issue #1152: [HUDI-454]
Redo hudi-cli log statements using SLF4J
Posted by GitBox <gi...@apache.org>.
cdmikechen commented on issue #1152: [HUDI-454] Redo hudi-cli log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1152#issuecomment-569575869
@yanghua It may be log4j2 depend error, and it's not caused by this change. Please ignore this :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] XuQianJin-Stars commented on a change in pull
request #1152: [HUDI-454] Redo hudi-cli log statements using SLF4J
Posted by GitBox <gi...@apache.org>.
XuQianJin-Stars commented on a change in pull request #1152: [HUDI-454] Redo hudi-cli log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1152#discussion_r361916113
##########
File path: hudi-cli/src/main/java/org/apache/hudi/cli/utils/InputStreamConsumer.java
##########
@@ -46,7 +47,7 @@ public void run() {
LOG.info(line);
}
} catch (IOException ioe) {
- LOG.severe(ioe.toString());
+ LOG.error(ioe.toString());
Review comment:
> Can we simplify it with `LOG.error(ioe);`?
logging -> SLF4J
FINEST -> TRACE
FINER -> DEBUG
FINE -> DEBUG
CONFIG -> INFO
INFO -> INFO
WARNING -> WARN
SEVERE -> ERROR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services