[GitHub] [arrow] lidavidm commented on a change in pull request #12705: ARROW-16019: [C++] Minimize chances of Minio connect errors

[GitBox <gi...@apache.org>]

lidavidm commented on a change in pull request #12705:
URL: https://github.com/apache/arrow/pull/12705#discussion_r834249384



##########
File path: cpp/src/arrow/filesystem/s3fs_test.cc
##########
@@ -100,15 +100,18 @@ class ShortRetryStrategy : public S3RetryStrategy {
       // which would trigger spurious retries.
       return false;
     }
-    return (error.should_retry || error.exception_name == "XMinioServerNotInitialized") &&
-           (attempted_retries * kRetryInterval < kMaxRetryDuration);
+    return IsRetryable(error) && (attempted_retries * kRetryInterval < kMaxRetryDuration);
   }
 
   int64_t CalculateDelayBeforeNextRetry(const AWSErrorDetail& error,
                                         int64_t attempted_retries) override {
     return kRetryInterval;
   }
 
+  bool IsRetryable(const AWSErrorDetail& error) {

Review comment:
       nit: `const`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org