[GitHub] [iceberg] dramaticlly commented on a diff in pull request #6797: Spark 3.3: Return partition stats for AddFiles procedure

["dramaticlly (via GitHub)" <gi...@apache.org>]

dramaticlly commented on code in PR #6797:
URL: https://github.com/apache/iceberg/pull/6797#discussion_r1106222540


##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/procedures/AddFilesProcedure.java:
##########
@@ -120,9 +121,16 @@ public InternalRow[] call(InternalRow args) {
       checkDuplicateFiles = args.getBoolean(3);
     }
 
-    long addedFilesCount =
-        importToIceberg(tableIdent, sourceIdent, partitionFilter, checkDuplicateFiles);
-    return new InternalRow[] {newInternalRow(addedFilesCount)};
+    return importToIceberg(tableIdent, sourceIdent, partitionFilter, checkDuplicateFiles);
+  }
+
+  private InternalRow[] toOutputRows(Snapshot snapshot) {
+    return new InternalRow[] {

Review Comment:
   thank you @RussellSpitzer , now they looks better now. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org