You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jonathan Hsieh (JIRA)" <ji...@apache.org> on 2012/12/29 01:20:12 UTC
[jira] [Comment Edited] (HBASE-7207) Consolidate snapshot related
classes into fewer packages
[ https://issues.apache.org/jira/browse/HBASE-7207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540657#comment-13540657 ]
Jonathan Hsieh edited comment on HBASE-7207 at 12/29/12 12:18 AM:
------------------------------------------------------------------
{code}
jon@swoop:~/proj/hbase$ ls -la hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/
total 176
drwxr-xr-x 2 jon jon 4096 2012-12-28 16:08 .
drwxr-xr-x 30 jon jon 4096 2012-12-28 16:08 ..
-rw-r--r-- 1 jon jon 3717 2012-12-28 16:08 CopyRecoveredEditsTask.java
-rw-r--r-- 1 jon jon 1926 2012-12-28 16:08 CorruptedSnapshotException.java
-rw-r--r-- 1 jon jon 1436 2012-12-28 16:08 ExportSnapshotException.java
-rw-r--r-- 1 jon jon 27015 2012-12-28 16:08 ExportSnapshot.java
-rw-r--r-- 1 jon jon 2667 2012-12-28 16:08 HBaseSnapshotException.java
-rw-r--r-- 1 jon jon 4953 2012-12-28 16:08 ReferenceRegionHFilesTask.java
-rw-r--r-- 1 jon jon 4454 2012-12-28 16:08 ReferenceServerWALsTask.java
-rw-r--r-- 1 jon jon 1525 2012-12-28 16:08 RestoreSnapshotException.java
-rw-r--r-- 1 jon jon 16515 2012-12-28 16:08 RestoreSnapshotHelper.java
-rw-r--r-- 1 jon jon 1997 2012-12-28 16:08 SnapshotCreationException.java
-rw-r--r-- 1 jon jon 16282 2012-12-28 16:08 SnapshotDescriptionUtils.java
-rw-r--r-- 1 jon jon 1666 2012-12-28 16:08 SnapshotDoesNotExistException.java
-rw-r--r-- 1 jon jon 1518 2012-12-28 16:08 SnapshotExistsException.java
-rw-r--r-- 1 jon jon 7455 2012-12-28 16:08 SnapshotLogSplitter.java
-rw-r--r-- 1 jon jon 9495 2012-12-28 13:31 SnapshotReferenceUtil.java
-rw-r--r-- 1 jon jon 2396 2012-12-28 16:08 SnapshotTask.java
-rw-r--r-- 1 jon jon 3046 2012-12-28 16:08 TableInfoCopyTask.java
-rw-r--r-- 1 jon jon 1634 2012-12-28 16:08 TablePartiallyOpenException.java
-rw-r--r-- 1 jon jon 13722 2012-12-28 16:08 TakeSnapshotUtils.java
-rw-r--r-- 1 jon jon 1651 2012-12-28 16:08 UnexpectedSnapshotException.java
-rw-r--r-- 1 jon jon 1429 2012-12-28 16:08 UnknownSnapshotException.java
{code}
was (Author: jmhsieh):
jon@swoop:~/proj/hbase$ ls -la hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/
total 176
drwxr-xr-x 2 jon jon 4096 2012-12-28 16:08 .
drwxr-xr-x 30 jon jon 4096 2012-12-28 16:08 ..
-rw-r--r-- 1 jon jon 3717 2012-12-28 16:08 CopyRecoveredEditsTask.java
-rw-r--r-- 1 jon jon 1926 2012-12-28 16:08 CorruptedSnapshotException.java
-rw-r--r-- 1 jon jon 1436 2012-12-28 16:08 ExportSnapshotException.java
-rw-r--r-- 1 jon jon 27015 2012-12-28 16:08 ExportSnapshot.java
-rw-r--r-- 1 jon jon 2667 2012-12-28 16:08 HBaseSnapshotException.java
-rw-r--r-- 1 jon jon 4953 2012-12-28 16:08 ReferenceRegionHFilesTask.java
-rw-r--r-- 1 jon jon 4454 2012-12-28 16:08 ReferenceServerWALsTask.java
-rw-r--r-- 1 jon jon 1525 2012-12-28 16:08 RestoreSnapshotException.java
-rw-r--r-- 1 jon jon 16515 2012-12-28 16:08 RestoreSnapshotHelper.java
-rw-r--r-- 1 jon jon 1997 2012-12-28 16:08 SnapshotCreationException.java
-rw-r--r-- 1 jon jon 16282 2012-12-28 16:08 SnapshotDescriptionUtils.java
-rw-r--r-- 1 jon jon 1666 2012-12-28 16:08 SnapshotDoesNotExistException.java
-rw-r--r-- 1 jon jon 1518 2012-12-28 16:08 SnapshotExistsException.java
-rw-r--r-- 1 jon jon 7455 2012-12-28 16:08 SnapshotLogSplitter.java
-rw-r--r-- 1 jon jon 9495 2012-12-28 13:31 SnapshotReferenceUtil.java
-rw-r--r-- 1 jon jon 2396 2012-12-28 16:08 SnapshotTask.java
-rw-r--r-- 1 jon jon 3046 2012-12-28 16:08 TableInfoCopyTask.java
-rw-r--r-- 1 jon jon 1634 2012-12-28 16:08 TablePartiallyOpenException.java
-rw-r--r-- 1 jon jon 13722 2012-12-28 16:08 TakeSnapshotUtils.java
-rw-r--r-- 1 jon jon 1651 2012-12-28 16:08 UnexpectedSnapshotException.java
-rw-r--r-- 1 jon jon 1429 2012-12-28 16:08 UnknownSnapshotException.java
> Consolidate snapshot related classes into fewer packages
> --------------------------------------------------------
>
> Key: HBASE-7207
> URL: https://issues.apache.org/jira/browse/HBASE-7207
> Project: HBase
> Issue Type: Sub-task
> Components: snapshots
> Affects Versions: hbase-6055
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: hbase-6055, 0.96.0
>
> Attachments: hbase-7207.patch, pre-hbase-7207.patch
>
>
> The snapshot branch seems to have more packages with fewer classes present in each. We should consolidate them down to a core set. I'm suggesting limiting it to:
> o.a.h.h.errorhandling (move o.a.h.h.server.errorhandling.** to this package)
> o.a.h.h.procedure (eliminate procedure.member, procedure.coordinator, possibly add zk for the zk implementation)
> o.a.h.h.snapshot (move o.a.h.h.server.snapshots.** to this package)
> o.a.h.h.master.snapshot (fold subpackages in)
> o.a.h.h.regionserver.snapshot (fold subpackges in)
> Likely move all TestSnapshotFrom* to o.a.h.h.snapshot.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira