You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/07/20 15:57:08 UTC
[GitHub] [incubator-echarts] susiwen8 opened a new pull request #12998: Add fill color for Pie label
susiwen8 opened a new pull request #12998:
URL: https://github.com/apache/incubator-echarts/pull/12998
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
Fix pie label color
### Fixed issues
<!--
- #xxxx: ...
-->
## Details
### Before: What was the problem?
<img width="377" alt="Screen Shot 2020-07-20 at 23 56 04" src="https://user-images.githubusercontent.com/20318608/87958877-a94d6f80-cae4-11ea-83b9-055a79883f0b.png">
### After: How is it fixed in this PR?
<img width="424" alt="Screen Shot 2020-07-20 at 23 55 49" src="https://user-images.githubusercontent.com/20318608/87958859-a2266180-cae4-11ea-83f0-926c33f9d4d6.png">
## Usage
### Are there any API changes?
- [ ] The API has been changed.
<!-- LIST THE API CHANGES HERE -->
### Related test cases or examples to use the new APIs
NA.
## Others
### Merging options
- [ ] Please squash the commits into a single one when merge.
### Other information
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang commented on pull request #12998: Add fill color for Pie label
Posted by GitBox <gi...@apache.org>.
pissang commented on pull request #12998:
URL: https://github.com/apache/incubator-echarts/pull/12998#issuecomment-661647153
@susiwen8 Not sure about `labelLine` yet. But it won't be as bad as text when using light colors. And we need to use `labelLine` to connect the label and sector. In this case, color will help.
But I have to admit that `labelLine` with gray color is also very nice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] susiwen8 edited a comment on pull request #12998: Add fill color for Pie label
Posted by GitBox <gi...@apache.org>.
susiwen8 edited a comment on pull request #12998:
URL: https://github.com/apache/incubator-echarts/pull/12998#issuecomment-661607460
And `lableline`? Should those be dark too? @pissang
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang commented on pull request #12998: Add fill color for Pie label
Posted by GitBox <gi...@apache.org>.
pissang commented on pull request #12998:
URL: https://github.com/apache/incubator-echarts/pull/12998#issuecomment-661606125
Using dark colors in labels is by design. Because the new color theme may be too bright for displaying labels.
Developers can still write `color: 'inherit'` to use the color of the sector.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang edited a comment on pull request #12998: Add fill color for Pie label
Posted by GitBox <gi...@apache.org>.
pissang edited a comment on pull request #12998:
URL: https://github.com/apache/incubator-echarts/pull/12998#issuecomment-661647153
@susiwen8 Not sure about `labelLine` yet. It won't be as bad as text when using light colors. And we need to use `labelLine` to connect the label and sector. In this case, color will help.
But I have to admit that `labelLine` with gray color is also very nice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] susiwen8 closed pull request #12998: Add fill color for Pie label
Posted by GitBox <gi...@apache.org>.
susiwen8 closed pull request #12998:
URL: https://github.com/apache/incubator-echarts/pull/12998
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] susiwen8 commented on pull request #12998: Add fill color for Pie label
Posted by GitBox <gi...@apache.org>.
susiwen8 commented on pull request #12998:
URL: https://github.com/apache/incubator-echarts/pull/12998#issuecomment-661607460
And `lableline`? Should those be dark too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #12998: Add fill color for Pie label
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #12998:
URL: https://github.com/apache/incubator-echarts/pull/12998#issuecomment-661127677
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org