You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/07/04 17:44:27 UTC
[GitHub] [cordova-plugin-media] timbru31 opened a new pull request #285: WIP: fix: remove deprecated platform code snippets
timbru31 opened a new pull request #285:
URL: https://github.com/apache/cordova-plugin-media/pull/285
### Motivation and Context
Removes references to removed platforms. Should have been part of #157. Depends on #283.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-media] timbru31 commented on a change in pull request #285: WIP: fix: remove deprecated platform code snippets
Posted by GitBox <gi...@apache.org>.
timbru31 commented on a change in pull request #285:
URL: https://github.com/apache/cordova-plugin-media/pull/285#discussion_r450077852
##########
File path: tests/tests.js
##########
@@ -42,10 +41,6 @@ var isAudioSupported = isWindows
? !window.SAUCELABS_ENV
: true;
-var isKitKat =
- cordova.platformId === 'android' &&
- /Android\s4\.4/.test(window.navigator.userAgent);
-
Review comment:
Fortunately, it's just the test code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-media] erisu commented on a change in pull request #285: WIP: fix: remove deprecated platform code snippets
Posted by GitBox <gi...@apache.org>.
erisu commented on a change in pull request #285:
URL: https://github.com/apache/cordova-plugin-media/pull/285#discussion_r449937471
##########
File path: tests/tests.js
##########
@@ -42,10 +41,6 @@ var isAudioSupported = isWindows
? !window.SAUCELABS_ENV
: true;
-var isKitKat =
- cordova.platformId === 'android' &&
- /Android\s4\.4/.test(window.navigator.userAgent);
-
Review comment:
This might be considered breaking?
Might want to considered merging this PR after the versions is major bumped...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org