You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2022/08/03 19:36:26 UTC
[GitHub] [trafficserver] kanseiishikawa opened a new pull request, #8967: Fixes issue #8951 Client Request Body processing
kanseiishikawa opened a new pull request, #8967:
URL: https://github.com/apache/trafficserver/pull/8967
Fixes[https://github.com/apache/trafficserver/issues/8951](https://github.com/apache/trafficserver/issues/8951).
It's okay call to `do_drain_request_body` if `t_state.next_action` is `SM_ACTION_INTERNAL_CACHE_NOOP`.
Calling `do_drain_request_body` to process unwanted Body.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #8967: Fixes issue #8951 Client Request Body processing
Posted by GitBox <gi...@apache.org>.
bneradt commented on PR #8967:
URL: https://github.com/apache/trafficserver/pull/8967#issuecomment-1204418713
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras closed pull request #8967: Fixes issue #8951 Client Request Body processing
Posted by GitBox <gi...@apache.org>.
ywkaras closed pull request #8967: Fixes issue #8951 Client Request Body processing
URL: https://github.com/apache/trafficserver/pull/8967
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] github-actions[bot] commented on pull request #8967: Fixes issue #8951 Client Request Body processing
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8967:
URL: https://github.com/apache/trafficserver/pull/8967#issuecomment-1328433707
This pull request has been automatically marked as stale because it has not had recent activity. Marking it stale to flag it for further consideration by the community.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] github-actions[bot] closed pull request #8967: Fixes issue #8951 Client Request Body processing
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #8967: Fixes issue #8951 Client Request Body processing
URL: https://github.com/apache/trafficserver/pull/8967
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on a diff in pull request #8967: Fixes issue #8951 Client Responce Body processing
Posted by GitBox <gi...@apache.org>.
bryancall commented on code in PR #8967:
URL: https://github.com/apache/trafficserver/pull/8967#discussion_r929387863
##########
proxy/http/HttpSM.cc:
##########
@@ -7727,6 +7727,7 @@ HttpSM::set_next_state()
if (t_state.api_next_action == HttpTransact::SM_ACTION_API_SEND_RESPONSE_HDR) {
handle_api_return();
} else {
+ do_drain_request_body(t_state.hdr_info.client_response);
Review Comment:
Is there a reason you are doing this within the conditional and not always draining?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #8967: Fixes issue #8951 Client Request Body processing
Posted by GitBox <gi...@apache.org>.
bneradt commented on PR #8967:
URL: https://github.com/apache/trafficserver/pull/8967#issuecomment-1204421063
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on pull request #8967: Fixes issue #8951 Client Request Body processing
Posted by GitBox <gi...@apache.org>.
bryancall commented on PR #8967:
URL: https://github.com/apache/trafficserver/pull/8967#issuecomment-1230983490
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] kanseiishikawa commented on a diff in pull request #8967: Fixes issue #8951 Client Responce Body processing
Posted by GitBox <gi...@apache.org>.
kanseiishikawa commented on code in PR #8967:
URL: https://github.com/apache/trafficserver/pull/8967#discussion_r930022299
##########
proxy/http/HttpSM.cc:
##########
@@ -7727,6 +7727,7 @@ HttpSM::set_next_state()
if (t_state.api_next_action == HttpTransact::SM_ACTION_API_SEND_RESPONSE_HDR) {
handle_api_return();
} else {
+ do_drain_request_body(t_state.hdr_info.client_response);
Review Comment:
When I reproduced it in the same way as [https://github.com/apache/trafficserver/issues/8951](https://github.com/apache/trafficserver/issues/8951) , I did a drain here and the problem was solved.
I don't have a reason not always drain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org