You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/12/22 08:53:18 UTC
[GitHub] [pulsar-client-go] wolfstudy opened a new pull request, #922: Support batch index ack feature
wolfstudy opened a new pull request, #922:
URL: https://github.com/apache/pulsar-client-go/pull/922
Signed-off-by: xiaolongran <xi...@tencent.com>
Master Issue: #894
### Motivation
As #894 said, support batch index ack feature
### Modifications
- In ConsumerOptions, export `BatchIndexAcknowledgmentEnable` option, default: false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] panszobe commented on pull request #922: Support batch index ack feature
Posted by GitBox <gi...@apache.org>.
panszobe commented on PR #922:
URL: https://github.com/apache/pulsar-client-go/pull/922#issuecomment-1366338811
@BewareMyPower When will the task be completed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] BewareMyPower commented on a diff in pull request #922: Support batch index ack feature
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on code in PR #922:
URL: https://github.com/apache/pulsar-client-go/pull/922#discussion_r1057094089
##########
pulsar/consumer_partition.go:
##########
@@ -733,6 +734,7 @@ func (pc *partitionConsumer) internalAck(req *ackRequest) {
func (pc *partitionConsumer) MessageReceived(response *pb.CommandMessage, headersAndPayload internal.Buffer) error {
pbMsgID := response.GetMessageId()
+ ackSet := response.GetAckSet()
Review Comment:
The `ackSet` should be parsed into a `BitSet` to check if the messages should be skipped when constructing the messages from a batch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] BewareMyPower commented on pull request #922: Support batch index ack feature
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on PR #922:
URL: https://github.com/apache/pulsar-client-go/pull/922#issuecomment-1366275304
After the private chat with @wolfstudy, I will take over this task (#894). Close this PR first. /cc @hangc0276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] BewareMyPower commented on a diff in pull request #922: Support batch index ack feature
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on code in PR #922:
URL: https://github.com/apache/pulsar-client-go/pull/922#discussion_r1057092829
##########
pulsar/impl_message.go:
##########
@@ -350,17 +350,17 @@ func (msg *message) BrokerPublishTime() *time.Time {
return msg.brokerPublishTime
}
-func newAckTracker(size int) *ackTracker {
+func newAckTracker(batchMsgSize int) *ackTracker {
Review Comment:
It looks like the renaming is meaningless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] BewareMyPower commented on pull request #922: Support batch index ack feature
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on PR #922:
URL: https://github.com/apache/pulsar-client-go/pull/922#issuecomment-1366370249
I cannot guarantee the specific deadline, but it should not take much time. Maybe this or next week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] panszobe commented on a diff in pull request #922: Support batch index ack feature
Posted by GitBox <gi...@apache.org>.
panszobe commented on code in PR #922:
URL: https://github.com/apache/pulsar-client-go/pull/922#discussion_r1056129189
##########
pulsar/consumer_partition.go:
##########
@@ -733,6 +734,7 @@ func (pc *partitionConsumer) internalAck(req *ackRequest) {
func (pc *partitionConsumer) MessageReceived(response *pb.CommandMessage, headersAndPayload internal.Buffer) error {
pbMsgID := response.GetMessageId()
+ ackSet := response.GetAckSet()
Review Comment:
It seems that ackSet not handled to judge which msg is acked.
It maybe cause duplicated consuming.
Would you please have a look, thanks a lot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] BewareMyPower closed pull request #922: Support batch index ack feature
Posted by GitBox <gi...@apache.org>.
BewareMyPower closed pull request #922: Support batch index ack feature
URL: https://github.com/apache/pulsar-client-go/pull/922
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org