You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "AlbumenJ (via GitHub)" <gi...@apache.org> on 2023/06/07 05:51:11 UTC

[GitHub] [dubbo] AlbumenJ commented on a diff in pull request #12470: fix registry npe

AlbumenJ commented on code in PR #12470:
URL: https://github.com/apache/dubbo/pull/12470#discussion_r1220891909


##########
dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/RegistryNotifier.java:
##########
@@ -43,6 +43,8 @@ public abstract class RegistryNotifier {
     // for the first 10 notification will be notified immediately
     private final AtomicInteger executeTime = new AtomicInteger(0);
 
+    private final AtomicInteger rawAddressesVersion = new AtomicInteger(0);

Review Comment:
   ```suggestion
       private static final AtomicInteger rawAddressesVersion = new AtomicInteger(0);
   ``` 
   would be better



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org