You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "tanishqgandhi1908 (via GitHub)" <gi...@apache.org> on 2026/10/13 02:36:23 UTC
[PR] fix(frontend): refresh the Datasets and Models list view after revoking your own access [texera]
tanishqgandhi1908 opened a new pull request, #8965:
URL: https://github.com/apache/texera/pull/8965
### What changes were proposed in this PR?
In list view, the Datasets and Models pages bound the results list’s (refresh) to ngAfterViewInit(), which only subscribed to the user stream again. The search it triggered saw the same filters and sort and returned early, so the list was never reloaded. After revoking your own access, the item stayed listed until a page reload, and each refresh added another subscription that was never removed.
Both pages now bind (refresh)="search(true)", the forced search card view already uses.
Before: after revoking your own access to sales-2026, it is still listed:
<img width="1440" height="900" alt="before-2-revoke-own-access" src="https://github.com/user-attachments/assets/0bd7c55a-a538-43ca-885f-7935f877f67a" />
<img width="1440" height="900" alt="before-3-row-still-listed" src="https://github.com/user-attachments/assets/7a1a79ad-99fb-4972-8ca3-2b97762c740d" />
After: the item disappears right away on both pages:
<img width="1440" height="900" alt="after-2-datasets-row-gone" src="https://github.com/user-attachments/assets/2be72235-895e-457f-ba8d-1d70092d5ce0" />
<img width="1440" height="900" alt="after-4-models-row-gone" src="https://github.com/user-attachments/assets/749ff178-a843-4ce5-9087-2c91feecace8" />
### Any related issues, documentation, discussions?
Closes #8964
### How was this PR tested?
Added a case to each of user-dataset.component.spec.ts and user-model.component.spec.ts: a refresh from the results list runs a forced search. Both fail without the fix.
cd frontend
yarn ng test --watch=false --include='**/user-dataset.component.spec.ts' --include='**/user-model.component.spec.ts'
Tests 65 passed (65)
Also checked against a local stack: as a WRITE collaborator in list view, revoking your own access removes the dataset or model from the list on both pages.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5.5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(frontend): refresh the Datasets and Models list view after revoking your own access [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8965:
URL: https://github.com/apache/texera/pull/8965#issuecomment-6136966769
<!-- backport-auto-label-report -->
### Backport auto-label report
This `fix:` PR was checked against each actively-supported release branch. A `release/*` label nominates a backport target; the branch's release manager approving this PR is what sends the fix there. The required **Backport Approvals** check stays red until every label below is approved, so each manager either approves or removes their own label — which is why the labels left on a merged PR are exactly the branches it reached.
| Release branch | Analysis |
| --- | --- |
| ✅ `release/v1.3` | Change detected on this branch — label added; this fix is queued to backport here. @mengw15 decides: approving sends the fix here, removing this label declines it. The merge waits on one or the other. Review requested. |
| ✅ `release/v1.2` | Change detected on this branch — label added; this fix is queued to backport here. @xuang7 decides: approving sends the fix here, removing this label declines it. The merge waits on one or the other. Review requested. |
_[Auto-label run](https://github.com/apache/texera/actions/runs/38337671002)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(frontend): refresh the Datasets and Models list view after revoking your own access [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8965:
URL: https://github.com/apache/texera/pull/8965#issuecomment-6180938838
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/8965?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 92.61%. Comparing base ([`6a29c59`](https://app.codecov.io/gh/apache/texera/commit/6a29c59c6312da95826b269fca2a6a14006fb34a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5787752`](https://app.codecov.io/gh/apache/texera/commit/5787752239f6c8eca1795a72258aa70c224f8b5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #8965 +/- ##
============================================
- Coverage 92.61% 92.61% -0.01%
- Complexity 5059 5061 +2
============================================
Files 1258 1258
Lines 53780 53777 -3
Branches 6707 6706 -1
============================================
- Hits 49811 49806 -5
- Misses 2313 2316 +3
+ Partials 1656 1655 -1
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/8965/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/8965/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.38% <ø> (ø)` | | Carriedforward from [9cf43f2](https://app.codecov.io/gh/apache/texera/commit/9cf43f2de96c9a1a8a93579835b8b7de66243d80?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/8965/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `99.16% <ø> (ø)` | | Carriedforward from [9cf43f2](https://app.codecov.io/gh/apache/texera/commit/9cf43f2de96c9a1a8a93579835b8b7de66243d80?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/8965/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `88.11% <ø> (+<0.01%)` | :arrow_up: | Carriedforward from [9cf43f2](https://app.codecov.io/gh/apache/texera/commit/9cf43f2de96c9a1a8a93579835b8b7de66243d80?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/8965/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `60.48% <ø> (ø)` | | Carriedforward from [9cf43f2](https://app.codecov.io/gh/apache/texera/commit/9cf43f2de96c9a1a8a93579835b8b7de66243d80?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/8965/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.37% <ø> (ø)` | | Carriedforward from [9cf43f2](https://app.codecov.io/gh/apache/texera/commit/9cf43f2de96c9a1a8a93579835b8b7de66243d80?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/8965/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `82.00% <ø> (ø)` | | Carriedforward from [9cf43f2](https://app.codecov.io/gh/apache/texera/commit/9cf43f2de96c9a1a8a93579835b8b7de66243d80?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/8965/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `96.59% <ø> (ø)` | | |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/8965/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `83.73% <ø> (ø)` | | Carriedforward from [9cf43f2](https://app.codecov.io/gh/apache/texera/commit/9cf43f2de96c9a1a8a93579835b8b7de66243d80?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/8965/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `98.52% <ø> (-0.07%)` | :arrow_down: | Carriedforward from [9cf43f2](https://app.codecov.io/gh/apache/texera/commit/9cf43f2de96c9a1a8a93579835b8b7de66243d80?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/8965/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `72.43% <ø> (ø)` | | Carriedforward from [9cf43f2](https://app.codecov.io/gh/apache/texera/commit/9cf43f2de96c9a1a8a93579835b8b7de66243d80?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/8965?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(frontend): refresh the Datasets and Models list view after revoking your own access [texera]
Posted by "xuang7 (via GitHub)" <gi...@apache.org>.
xuang7 merged PR #8965:
URL: https://github.com/apache/texera/pull/8965
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(frontend): refresh the Datasets and Models list view after revoking your own access [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8965:
URL: https://github.com/apache/texera/pull/8965#issuecomment-6136966050
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- No candidates found from `git blame` history.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org