You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/05 03:38:47 UTC
[GitHub] [flink] HuangXingBo opened a new pull request #14313: [FLINK-20475][doc] Fix the broken links in gettingStarted.zh.md
HuangXingBo opened a new pull request #14313:
URL: https://github.com/apache/flink/pull/14313
## What is the purpose of the change
*This pull request will fix the broken links in gettingStarted.zh.md*
## Brief change log
- *Fix the broken links in gettingStarted.zh.md*
## Verifying this change
- *Executing the script `build_docs.sh`*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14313: [FLINK-20475][doc] Fix the broken links in gettingStarted.zh.md
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14313:
URL: https://github.com/apache/flink/pull/14313#issuecomment-739118411
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6cf6eb565ed17de3f2201f9129be67f725cc8704",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10539",
"triggerID" : "6cf6eb565ed17de3f2201f9129be67f725cc8704",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6cf6eb565ed17de3f2201f9129be67f725cc8704 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10539)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14313: [FLINK-20475][doc] Fix the broken links in gettingStarted.zh.md
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14313:
URL: https://github.com/apache/flink/pull/14313#issuecomment-739117347
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 6cf6eb565ed17de3f2201f9129be67f725cc8704 (Sat Dec 05 03:40:53 UTC 2020)
**Warnings:**
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-20475).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14313: [FLINK-20475][doc] Fix the broken links in gettingStarted.zh.md
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14313:
URL: https://github.com/apache/flink/pull/14313#issuecomment-739118411
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6cf6eb565ed17de3f2201f9129be67f725cc8704",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6cf6eb565ed17de3f2201f9129be67f725cc8704",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6cf6eb565ed17de3f2201f9129be67f725cc8704 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sjwiesman commented on pull request #14313: [FLINK-20475][doc] Fix the broken links in gettingStarted.zh.md
Posted by GitBox <gi...@apache.org>.
sjwiesman commented on pull request #14313:
URL: https://github.com/apache/flink/pull/14313#issuecomment-740146712
It seems someone already merged in a fix. I'll go ahead and close this. thank you again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sjwiesman commented on pull request #14313: [FLINK-20475][doc] Fix the broken links in gettingStarted.zh.md
Posted by GitBox <gi...@apache.org>.
sjwiesman commented on pull request #14313:
URL: https://github.com/apache/flink/pull/14313#issuecomment-740145598
This was my fault, thank you for fixing it @HuangXingBo!
Looks good, I'll go ahead and merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sjwiesman closed pull request #14313: [FLINK-20475][doc] Fix the broken links in gettingStarted.zh.md
Posted by GitBox <gi...@apache.org>.
sjwiesman closed pull request #14313:
URL: https://github.com/apache/flink/pull/14313
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] HuangXingBo commented on pull request #14313: [FLINK-20475][doc] Fix the broken links in gettingStarted.zh.md
Posted by GitBox <gi...@apache.org>.
HuangXingBo commented on pull request #14313:
URL: https://github.com/apache/flink/pull/14313#issuecomment-739117148
@dianfu Could you help review it? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14313: [FLINK-20475][doc] Fix the broken links in gettingStarted.zh.md
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14313:
URL: https://github.com/apache/flink/pull/14313#issuecomment-739118411
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6cf6eb565ed17de3f2201f9129be67f725cc8704",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10539",
"triggerID" : "6cf6eb565ed17de3f2201f9129be67f725cc8704",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6cf6eb565ed17de3f2201f9129be67f725cc8704 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10539)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org