You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@zookeeper.apache.org by "li4wang (via GitHub)" <gi...@apache.org> on 2023/12/13 01:25:57 UTC

Re: [PR] ZOOKEEPER-4767: New implementation of prometheus quantile metrics based on DataSketches [zookeeper]

li4wang commented on PR #2086:
URL: https://github.com/apache/zookeeper/pull/2086#issuecomment-1853119385

   Sorry didn't get chance to get to this until today. Thanks for contributing to this @Shawyeok . I like the idea of fixing the underneath Prometheus quantile computation issue in the prometheus client library.  Can you provide some details on the trade off this patch?
   
   > latency percentiles will be displayed with a relative delay (default is 60 seconds)
   
   Where does the latency come from? Is it possible to avoid it or reduce it?
   
   > each Summary metric will have a certain amount of permanent memory overhead
   Do you mean it takes more heap space permanently? How much is the overhead? 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org