[GitHub] john-bodley closed pull request #5271: [metric] Fixing ad-hoc metric for dual-line chart

[GitBox <gi...@apache.org>]

john-bodley closed pull request #5271: [metric] Fixing ad-hoc metric for dual-line chart
URL: https://github.com/apache/incubator-superset/pull/5271
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/viz.py b/superset/viz.py
index 6b5b68c38f..74b3553b7e 100644
--- a/superset/viz.py
+++ b/superset/viz.py
@@ -1317,6 +1317,7 @@ def to_series(self, df, classed=''):
             self.form_data.get('metric_2'),
         ]
         for i, m in enumerate(metrics):
+            m = utils.get_metric_name(m)
             ys = series[m]
             if df[m].dtype.kind not in 'biufc':
                 continue


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org