You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2002/11/06 11:12:41 UTC

DO NOT REPLY [Bug 14292] New: - Status message not included in HTTP response

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14292>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14292

Status message not included in HTTP response

           Summary: Status message not included in HTTP response
           Product: Tomcat 4
           Version: 4.1.12
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Critical
          Priority: Other
         Component: Connector:Coyote JK 2
        AssignedTo: tomcat-dev@jakarta.apache.org
        ReportedBy: stefan.proels@gmx.de


JkCoyote does not write a status message after the status code in the HTTP
response header. This causes problems with some proxies, e.g., domains hosted by
Strato which are forwarded through Strato's proxies.

There are actually 2 bugs which cause the problem:

1. JkCoyoteHandler.java always appends an empty status message instead of the
real one to the generated message. Here is my fix (relative to the current CVS
repository):

--------------------------------------------------------------------
--- JkCoyoteHandler.java	2002-11-06 10:51:19.000000000 +0100
+++ JkCoyoteHandler.java_new	2002-11-06 10:08:56.000000000 +0100
@@ -284,7 +284,10 @@
         msg.appendInt( res.getStatus() );
         
         // s->b conversion, message
-        msg.appendBytes( null );
+	MessageBytes mb = new MessageBytes();
+	mb.setString(res.getMessage());
+	c2b.convert (mb);
+        msg.appendBytes(mb);
         
         // XXX add headers
--------------------------------------------------------------------
         
2. Newly created Coyote Responses contain a status message of NULL instead of
"OK". Here is my fix:

--------------------------------------------------------------------
--- Response.java	2002-11-06 10:46:36.000000000 +0100
+++ Response.java_new	2002-11-06 10:04:49.000000000 +0100
@@ -102,7 +102,7 @@
     /**
      * Status message.
      */
-    protected String message = null;
+    protected String message = "OK";
 
 
     /**
@@ -316,7 +316,7 @@
         contentLength = -1;
 
         status = 200;
-        message = null;
+        message = "OK";
         headers.clear();
         
         // Force the PrintWriter to flush its data to the output
@@ -524,7 +524,7 @@
         characterEncoding = Constants.DEFAULT_CHARACTER_ENCODING;
         contentLength = -1;
         status = 200;
-        message = null;
+        message = "OK";
         commited = false;
         errorException = null;
         errorURI = null;
--------------------------------------------------------------------


CU,
Stefan

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>