You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Gautam Borad <gb...@gmail.com> on 2015/05/22 15:21:35 UTC

Review Request 34596: AMBARI-11338 Solr changes to Ranger Audit properties for all plugins

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34596/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Mahadev Konar, Selvamohan Neethiraj, and Velmurugan Periasamy.


Bugs: AMBARI-11338
    https://issues.apache.org/jira/browse/AMBARI-11338


Repository: ambari


Description
-------

Solr changes to Ranger Audit properties for all plugins


Diffs
-----

  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 01f082b 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py b29eb8e 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 647892a 
  ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py 37f7b40 
  ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-audit.xml 2801106 
  ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py 3d0ce0c 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py 59ec77c 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py 2198bcc 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/ranger-hbase-audit.xml adb53fe 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/ranger-hdfs-audit.xml 66dab3d 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-audit.xml aabfe31 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/KNOX/configuration/ranger-knox-audit.xml 1878c40 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml dd4451e 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-audit.xml 43870e6 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/ranger-yarn-audit.xml 25eddd4 
  ambari-web/app/data/HDP2.3/site_properties.js 5a351b5 

Diff: https://reviews.apache.org/r/34596/diff/


Testing
-------

Tested on a centos6 3 node cluster with Ranger and HDFS/HIVE/HBASE/KNOX/YARN


Thanks,

Gautam Borad

Re: Review Request 34596: AMBARI-11338 Solr changes to Ranger Audit properties for all plugins

Posted by Gautam Borad <gb...@gmail.com>.

> On May 22, 2015, 6:07 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py, line 71
> > <https://reviews.apache.org/r/34596/diff/1/?file=969194#file969194line71>
> >
> >     This depends on getting a config property that was created by the server at the time this command was scheduled. By the time this runs, there's a pontential for the active namenode to change.
> >     
> >     Instead, should retrieve the Active NameNode by querying it.
> >     Take a look at namenode_ha_state.py
> >     E.g., namenode_ha.get_address(NAMENODE_STATE.ACTIVE)
> >     
> >     This script is currently inside HDFS service, so you may want to move it out to common-services, and correct the references to it.

Setting a default string that user will update, like it was in Ambari-2.0. Will handle autopopulation in separate Jira, since its a bigger change.


- Gautam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34596/#review84945
-----------------------------------------------------------


On May 23, 2015, 9:43 a.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34596/
> -----------------------------------------------------------
> 
> (Updated May 23, 2015, 9:43 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Mahadev Konar, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-11338
>     https://issues.apache.org/jira/browse/AMBARI-11338
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Solr changes to Ranger Audit properties for all plugins
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 441e68e 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 03ca213 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py d180340 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py 37f7b40 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-audit.xml 2801106 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py 3d0ce0c 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py 59ec77c 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py 564f8ef 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/ranger-hbase-audit.xml adb53fe 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/ranger-hdfs-audit.xml 66dab3d 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-audit.xml aabfe31 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/KNOX/configuration/ranger-knox-audit.xml 1878c40 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml dd4451e 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-audit.xml 43870e6 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/ranger-yarn-audit.xml 25eddd4 
>   ambari-web/app/data/HDP2.3/site_properties.js 5a351b5 
> 
> Diff: https://reviews.apache.org/r/34596/diff/
> 
> 
> Testing
> -------
> 
> Tested on a centos6 3 node cluster with Ranger and HDFS/HIVE/HBASE/KNOX/YARN
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>

Re: Review Request 34596: AMBARI-11338 Solr changes to Ranger Audit properties for all plugins

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34596/#review84945
-----------------------------------------------------------



ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
<https://reviews.apache.org/r/34596/#comment136398>

    This depends on getting a config property that was created by the server at the time this command was scheduled. By the time this runs, there's a pontential for the active namenode to change.
    
    Instead, should retrieve the Active NameNode by querying it.
    Take a look at namenode_ha_state.py
    E.g., namenode_ha.get_address(NAMENODE_STATE.ACTIVE)
    
    This script is currently inside HDFS service, so you may want to move it out to common-services, and correct the references to it.


- Alejandro Fernandez


On May 22, 2015, 1:21 p.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34596/
> -----------------------------------------------------------
> 
> (Updated May 22, 2015, 1:21 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Mahadev Konar, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-11338
>     https://issues.apache.org/jira/browse/AMBARI-11338
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Solr changes to Ranger Audit properties for all plugins
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 01f082b 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py b29eb8e 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 647892a 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py 37f7b40 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-audit.xml 2801106 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py 3d0ce0c 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py 59ec77c 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py 2198bcc 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/ranger-hbase-audit.xml adb53fe 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/ranger-hdfs-audit.xml 66dab3d 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-audit.xml aabfe31 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/KNOX/configuration/ranger-knox-audit.xml 1878c40 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml dd4451e 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-audit.xml 43870e6 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/ranger-yarn-audit.xml 25eddd4 
>   ambari-web/app/data/HDP2.3/site_properties.js 5a351b5 
> 
> Diff: https://reviews.apache.org/r/34596/diff/
> 
> 
> Testing
> -------
> 
> Tested on a centos6 3 node cluster with Ranger and HDFS/HIVE/HBASE/KNOX/YARN
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>

Re: Review Request 34596: AMBARI-11338 Solr changes to Ranger Audit properties for all plugins

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34596/#review85103
-----------------------------------------------------------

Ship it!


Ship It!

- Alejandro Fernandez


On May 23, 2015, 9:43 a.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34596/
> -----------------------------------------------------------
> 
> (Updated May 23, 2015, 9:43 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Mahadev Konar, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-11338
>     https://issues.apache.org/jira/browse/AMBARI-11338
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Solr changes to Ranger Audit properties for all plugins
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 441e68e 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 03ca213 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py d180340 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py 37f7b40 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-audit.xml 2801106 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py 3d0ce0c 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py 59ec77c 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py 564f8ef 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/ranger-hbase-audit.xml adb53fe 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/ranger-hdfs-audit.xml 66dab3d 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-audit.xml aabfe31 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/KNOX/configuration/ranger-knox-audit.xml 1878c40 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml dd4451e 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-audit.xml 43870e6 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/ranger-yarn-audit.xml 25eddd4 
>   ambari-web/app/data/HDP2.3/site_properties.js 5a351b5 
> 
> Diff: https://reviews.apache.org/r/34596/diff/
> 
> 
> Testing
> -------
> 
> Tested on a centos6 3 node cluster with Ranger and HDFS/HIVE/HBASE/KNOX/YARN
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>

Re: Review Request 34596: AMBARI-11338 Solr changes to Ranger Audit properties for all plugins

Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34596/
-----------------------------------------------------------

(Updated May 23, 2015, 9:43 a.m.)


Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Mahadev Konar, Selvamohan Neethiraj, and Velmurugan Periasamy.


Changes
-------

Handled request comments. Moving out namenode autopopulation since that will be a bigger change, needing more testing.


Bugs: AMBARI-11338
    https://issues.apache.org/jira/browse/AMBARI-11338


Repository: ambari


Description
-------

Solr changes to Ranger Audit properties for all plugins


Diffs (updated)
-----

  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 441e68e 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 03ca213 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py d180340 
  ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py 37f7b40 
  ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-audit.xml 2801106 
  ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py 3d0ce0c 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py 59ec77c 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py 564f8ef 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/ranger-hbase-audit.xml adb53fe 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/ranger-hdfs-audit.xml 66dab3d 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-audit.xml aabfe31 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/KNOX/configuration/ranger-knox-audit.xml 1878c40 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml dd4451e 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-audit.xml 43870e6 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/ranger-yarn-audit.xml 25eddd4 
  ambari-web/app/data/HDP2.3/site_properties.js 5a351b5 

Diff: https://reviews.apache.org/r/34596/diff/


Testing
-------

Tested on a centos6 3 node cluster with Ranger and HDFS/HIVE/HBASE/KNOX/YARN


Thanks,

Gautam Borad