You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/06/14 07:59:05 UTC
[GitHub] [kafka] dajac opened a new pull request, #12292: MINOR: KRaft nodes not shutdown correctly when using one controller in colocated mode
dajac opened a new pull request, #12292:
URL: https://github.com/apache/kafka/pull/12292
Found a bug in `KafkaService.stop_node`. `round(self.num_nodes_controller_role / 2)` rounds to the closest even choice. When only one controller is used in colocated mode, it rounds to zero. If the colocated controller is the first node shutdown, the remaining ones fails to stop within the 60s timeout because they are stuck in controlled shutdown. Those nodes are eventually killed. It is better to use `match.ceil` here.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac closed pull request #12292: MINOR: KRaft nodes not shutdown correctly when using one controller in colocated mode
Posted by GitBox <gi...@apache.org>.
dajac closed pull request #12292: MINOR: KRaft nodes not shutdown correctly when using one controller in colocated mode
URL: https://github.com/apache/kafka/pull/12292
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #12292: MINOR: KRaft nodes not shutdown correctly when using one controller in colocated mode
Posted by GitBox <gi...@apache.org>.
dajac commented on PR #12292:
URL: https://github.com/apache/kafka/pull/12292#issuecomment-1156567953
Already fixed by https://github.com/apache/kafka/pull/11238.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org