You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/01/26 21:23:52 UTC
[GitHub] [incubator-mxnet] access2rohit opened a new pull request #19792: removing forked and adding overall timeout for 2 hrs
access2rohit opened a new pull request #19792:
URL: https://github.com/apache/incubator-mxnet/pull/19792
## Description ##
`--forked` option causes significant slowdown in pytest runs hence it is better to remove that option and simply increase timeout for large tensor tests
## Checklist ##
### Essentials ###
- [x] Changes are complete (i.e. I finished coding on this PR)
- [x] All changes have test coverage
- [x] Code is well-documented
## Testing ##
- If this change is a backward incompatible change, why must this change be made.
- Interesting edge cases to note here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #19792: removing forked and adding overall timeout for 2 hrs
Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #19792:
URL: https://github.com/apache/incubator-mxnet/pull/19792#issuecomment-768254170
Can you provide more details? Why would removing `--fork` make the tests run longer (ie. timeout increase is needed)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19792: removing forked and adding overall timeout for 2 hrs
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19792:
URL: https://github.com/apache/incubator-mxnet/pull/19792#issuecomment-767836860
Hey @access2rohit , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [miscellaneous, sanity, centos-gpu, windows-cpu, unix-cpu, unix-gpu, clang, windows-gpu, centos-cpu, website, edge]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit edited a comment on pull request #19792: removing forked and adding overall timeout for 2 hrs
Posted by GitBox <gi...@apache.org>.
access2rohit edited a comment on pull request #19792:
URL: https://github.com/apache/incubator-mxnet/pull/19792#issuecomment-768620375
> Can you provide more details? Why would removing `--fork` make the tests run longer (ie. timeout increase is needed)?
@leezu
If run 1-2 tests with and without `--forked` then without forked takes 2-3 mins and finishes successfully but with forked it hangs till the timeout provided in `pytest.ini` isn't reached. With `--forked` option neither of the following timeout override options take effect:
`@pytest.mark.timeout(3600)`
`export PYTEST_TIMEOUT=3600`
`--timeout=3600`
It seems that with forked individual timeout is picked only from `pytest.ini` and even individual decorators don't seem to work only global timeout can be set in them which is not meaningful if individual timeout is 20 mins for each test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit edited a comment on pull request #19792: removing forked and adding overall timeout for 2 hrs
Posted by GitBox <gi...@apache.org>.
access2rohit edited a comment on pull request #19792:
URL: https://github.com/apache/incubator-mxnet/pull/19792#issuecomment-768620375
> Can you provide more details? Why would removing `--fork` make the tests run longer (ie. timeout increase is needed)?
@leezu
If run 1-2 tests with and without `--forked` then without forked takes 2-3 mins and finishes successfully but with forked it hangs till the timeout provided in `pytest.ini` isn't reached. With `--forked` option neither of the following timeout override options take effect:
`@pytest.mark.timeout(3600)`
`export PYTEST_TIMEOUT=3600`
`--timeout=3600`
It seems that with forked individual timeout is picked only from `pytest.ini` and even individual decorators don't seem to work only global timeout can be set in them which is not meaningful if individual timeout is 20 mins for each test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit commented on pull request #19792: removing forked and adding overall timeout for 2 hrs
Posted by GitBox <gi...@apache.org>.
access2rohit commented on pull request #19792:
URL: https://github.com/apache/incubator-mxnet/pull/19792#issuecomment-768620375
> Can you provide more details? Why would removing `--fork` make the tests run longer (ie. timeout increase is needed)?
@leezu
If run 1-2 tests with and without `--forked` then without forked takes 2-3 mins and finishes successfully but with forked it hangs till the timeout provided in `pytest.ini` isn't reached. With `--forked` option neither of the following timeout override options take effect:
`@pytest.mark.timeout(3600)`
`export PYTEST_TIMEOUT=3600`
`--timeout=3600`
It seems that with forked individual timeout is picked only from `pytest.ini` and even individual decorators don't seem to work only global timeout can be set in then which is not meaningful if individual timeout is 20 mins for each test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Zha0q1 merged pull request #19792: LT Nightly tests: removing forked and adding overall timeout for 2 hrs
Posted by GitBox <gi...@apache.org>.
Zha0q1 merged pull request #19792:
URL: https://github.com/apache/incubator-mxnet/pull/19792
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org