[GitHub] [iceberg] ajantha-bhat commented on a diff in pull request #6117: Fix typo in `_ManifestEvalVisitor.visit_equal`

[GitBox <gi...@apache.org>]

ajantha-bhat commented on code in PR #6117:
URL: https://github.com/apache/iceberg/pull/6117#discussion_r1013615833


##########
python/pyiceberg/expressions/visitors.py:
##########
@@ -526,7 +526,7 @@ def visit_equal(self, term: BoundTerm, literal: Literal[Any]) -> bool:
         if lower > literal.value:
             return ROWS_CANNOT_MATCH
 
-        upper = _from_byte_buffer(term.ref().field.field_type, field.lower_bound)
+        upper = _from_byte_buffer(term.ref().field.field_type, field.upper_bound)

Review Comment:
   good finding 👍🏻. 
   
   nit: maybe good to have unit tests around these. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org