[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29895: [SPARK-33019][CORE] Use spark.hadoop.mapreduce.fileoutputcommitter.algorithm.version=1 by default

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #29895:
URL: https://github.com/apache/spark/pull/29895#discussion_r496405283



##########
File path: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala
##########
@@ -462,6 +462,9 @@ private[spark] object SparkHadoopUtil {
     for ((key, value) <- conf.getAll if key.startsWith("spark.hadoop.")) {
       hadoopConf.set(key.substring("spark.hadoop.".length), value)
     }
+    if (conf.getOption("spark.hadoop.mapreduce.fileoutputcommitter.algorithm.version").isEmpty) {
+      hadoopConf.set("mapreduce.fileoutputcommitter.algorithm.version", "1")

Review comment:
       Thanks for review, but we cannot use it because Apache Hadoop already loads the default value of `mapreduce.fileoutputcommitter.algorithm.version`, @HyukjinKwon .




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org