You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "Caideyipi (via GitHub)" <gi...@apache.org> on 2026/05/29 04:40:44 UTC
[PR] [dev/1.3] Pipe: Harden legacy pipe file transfer validation and access checks [iotdb]
Caideyipi opened a new pull request, #17791:
URL: https://github.com/apache/iotdb/pull/17791
Backport/cherry-pick of 33c3ef7196b10bbd269f4d45bfb48f7fd39aa374 (#17741) to dev/1.3. Testing: .\\mvnw.cmd -pl iotdb-core/datanode spotless:apply passed. Targeted IoTDBLegacyPipeReceiverAgentTest could not complete locally because datanode compile fails on existing pipe API mismatch outside this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [dev/1.3] Pipe: Harden legacy pipe file transfer validation and access checks [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17791:
URL: https://github.com/apache/iotdb/pull/17791#issuecomment-4590197490
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17791) **Quality Gate passed**
Issues
 [2 New issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=17791&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=17791&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=17791&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=17791&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=17791&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17791)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [dev/1.3] Pipe: Harden legacy pipe file transfer validation and access checks [iotdb]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #17791:
URL: https://github.com/apache/iotdb/pull/17791#issuecomment-4590463801
## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/17791?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `27.41935%` with `45 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 42.39%. Comparing base ([`5d4277a`](https://app.codecov.io/gh/apache/iotdb/commit/5d4277a49a1c17af753dc767604c6791bab393e3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`258f7c1`](https://app.codecov.io/gh/apache/iotdb/commit/258f7c19bf5c4c45fc00bc72b343fa759e8c82e6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/iotdb/pull/17791?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../db/protocol/thrift/impl/ClientRPCServiceImpl.java](https://app.codecov.io/gh/apache/iotdb/pull/17791?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fprotocol%2Fthrift%2Fimpl%2FClientRPCServiceImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcHJvdG9jb2wvdGhyaWZ0L2ltcGwvQ2xpZW50UlBDU2VydmljZUltcGwuamF2YQ==) | 0.00% | [24 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/17791?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pipe/sink/protocol/legacy/IoTDBLegacyPipeSink.java](https://app.codecov.io/gh/apache/iotdb/pull/17791?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fpipe%2Fsink%2Fprotocol%2Flegacy%2FIoTDBLegacyPipeSink.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcGlwZS9zaW5rL3Byb3RvY29sL2xlZ2FjeS9Jb1REQkxlZ2FjeVBpcGVTaW5rLmphdmE=) | 0.00% | [16 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/17791?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../protocol/legacy/IoTDBLegacyPipeReceiverAgent.java](https://app.codecov.io/gh/apache/iotdb/pull/17791?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fpipe%2Freceiver%2Fprotocol%2Flegacy%2FIoTDBLegacyPipeReceiverAgent.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcGlwZS9yZWNlaXZlci9wcm90b2NvbC9sZWdhY3kvSW9UREJMZWdhY3lQaXBlUmVjZWl2ZXJBZ2VudC5qYXZh) | 77.27% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/17791?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## dev/1.3 #17791 +/- ##
=============================================
+ Coverage 42.33% 42.39% +0.05%
Complexity 241 241
=============================================
Files 3616 3616
Lines 239350 239396 +46
Branches 29098 29104 +6
=============================================
+ Hits 101324 101485 +161
+ Misses 138026 137911 -115
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/iotdb/pull/17791?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [dev/1.3] Pipe: Harden legacy pipe file transfer validation and access checks [iotdb]
Posted by "jt2594838 (via GitHub)" <gi...@apache.org>.
jt2594838 merged PR #17791:
URL: https://github.com/apache/iotdb/pull/17791
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org