You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ratis.apache.org by GitBox <gi...@apache.org> on 2020/05/07 11:27:59 UTC
[GitHub] [incubator-ratis] mukul1987 opened a new pull request #94: RATIS-932. Avoid usage of ratis-thirdparty-hadoop in ratis-hadoop module.
mukul1987 opened a new pull request #94:
URL: https://github.com/apache/incubator-ratis/pull/94
This patch avoids dependency of Ratis on ratis-hadoop-thirdparty, and takes a direct dependency on Hadoop. This helps in simplifying dependency management in Ratis.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] szetszwo commented on pull request #94: RATIS-932. Avoid usage of ratis-thirdparty-hadoop in ratis-hadoop module.
Posted by GitBox <gi...@apache.org>.
szetszwo commented on pull request #94:
URL: https://github.com/apache/incubator-ratis/pull/94#issuecomment-625938510
+1 the change looks good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] lokeshj1703 commented on pull request #94: RATIS-932. Avoid usage of ratis-thirdparty-hadoop in ratis-hadoop module.
Posted by GitBox <gi...@apache.org>.
lokeshj1703 commented on pull request #94:
URL: https://github.com/apache/incubator-ratis/pull/94#issuecomment-625738688
@mukul1987 Thanks for the clarification! I'm +1 on the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] mukul1987 commented on pull request #94: RATIS-932. Avoid usage of ratis-thirdparty-hadoop in ratis-hadoop module.
Posted by GitBox <gi...@apache.org>.
mukul1987 commented on pull request #94:
URL: https://github.com/apache/incubator-ratis/pull/94#issuecomment-625736006
Thanks for the review @lokeshj1703 , I did a quick compare of the file ProtobufRpcEngine and also reading from the comments on the file. The file is a copy of ProtobufRpcEngine to use the shaded library. It is safe to remove the reference.
/**
* Copied from {@link org.apache.hadoop.ipc.ProtobufRpcEngine}
* and replaced the protobuf classes with the shaded classes.
*/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] lokeshj1703 commented on pull request #94: RATIS-932. Avoid usage of ratis-thirdparty-hadoop in ratis-hadoop module.
Posted by GitBox <gi...@apache.org>.
lokeshj1703 commented on pull request #94:
URL: https://github.com/apache/incubator-ratis/pull/94#issuecomment-626470047
@mukul1987 We can fix the tests as part of separate jira. +1 for the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] lokeshj1703 edited a comment on pull request #94: RATIS-932. Avoid usage of ratis-thirdparty-hadoop in ratis-hadoop module.
Posted by GitBox <gi...@apache.org>.
lokeshj1703 edited a comment on pull request #94:
URL: https://github.com/apache/incubator-ratis/pull/94#issuecomment-625781885
@mukul1987 the hadoop tests are failing with the PR. It might be related to the ProtobufRpcEngineShaded file. By default hadoop tests are disabled so failure did not show up in unit tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] lokeshj1703 commented on pull request #94: RATIS-932. Avoid usage of ratis-thirdparty-hadoop in ratis-hadoop module.
Posted by GitBox <gi...@apache.org>.
lokeshj1703 commented on pull request #94:
URL: https://github.com/apache/incubator-ratis/pull/94#issuecomment-625781885
@mukul1987 the hadoop tests are failing with the PR. It might be related to the ProtobufRpcEngineShaded file. By default hadoop tests are disabled so failure did not show up in acceptance tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org