[GitHub] [flink] KurtYoung commented on a change in pull request #8127: [FLINK-12140][table-planner-blink] Support e2e sort merge join operator in batch mode

[GitBox <gi...@apache.org>]

KurtYoung commented on a change in pull request #8127: [FLINK-12140][table-planner-blink] Support e2e sort merge join operator in batch mode
URL: https://github.com/apache/flink/pull/8127#discussion_r274278517
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/plan/nodes/physical/batch/BatchExecSortMergeJoin.scala
 ##########
 @@ -104,6 +117,109 @@ trait BatchExecSortMergeJoinBase extends BatchExecJoinBase {
     val rowCount = mq.getRowCount(this)
     costFactory.makeCost(rowCount, cpuCost, 0, 0, sortMemCost)
   }
+
+  /**
+    * Now must be full dam without two input operator chain.
+    * TODO two input operator chain
+    */
+  override def getDamBehavior: DamBehavior = {
+    DamBehavior.FULL_DAM
+//    if (!leftSorted && !rightSorted) {
 
 Review comment:
   remove this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services