Re: [PR] Migrate away from per-segment-per-threadlocals on SegmentReader [lucene]

["0ctopus13prime (via GitHub)" <gi...@apache.org>]

0ctopus13prime commented on PR #11998:
URL: https://github.com/apache/lucene/pull/11998#issuecomment-2790785517

   @rmuir 
   Hi Robert, just curious what is the contract of calling `close` of cloned stored fields?
   Codec reader gets stored fields in [here](https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/index/CodecReader.java#L88C33-L88C48), and SegmentReader return a cloned stored fields reader in [here](https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/index/SegmentReader.java#L264), but it never gets closed!
   
   Bit confusing, but I'm assuming the contract is the shallow copied, so it's not suppose to be closed right?
   Would be appreciated if you shed some lights here.
   Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org