You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "shuke987 (via GitHub)" <gi...@apache.org> on 2026/10/16 02:23:34 UTC
[PR] [fix](ci) Preserve failed review submission diagnostics [doris]
shuke987 opened a new pull request, #69154:
URL: https://github.com/apache/doris/pull/69154
### What problem does this PR solve?
When a GitHub review POST fails, the helper currently discards captured stdout/stderr. Its persisted intent correctly prevents reposting, but subsequent verification reports only that no final review was found. The workflow archives only rejected candidates, leaving the attempted submission and original API failure unavailable.
This change records credential-redacted API output, endpoint/method, exit status and timeout details for failed commands and invalid JSON responses. It retains earlier diagnostics across readback attempts, includes the original API error in unverified-delivery failures, and uploads the submission intent, rejected candidate and API diagnostics as an explicit three-file failure artifact.
Exact GitHub readback, submission ownership, stale-head checks and the no-repost guard are unchanged. The tests inject HTTP 422 and timeout responses; they do not assert that a historical production failure was HTTP 422.
### Release note
None
### Check List (For Author)
- Test
- [x] Unit Test: 37 submission tests passed; 81 runner tests completed successfully, with 3 Linux-only tests skipped on macOS.
- [x] Manual test: actionlint v1.7.7 passed with only the existing unsupported `concurrency.queue` key ignored; optional ShellCheck/Pyflakes disabled. Python syntax and whitespace checks passed.
- Behavior changed:
- [x] Yes. Failed review runs retain actionable API diagnostics and candidate artifacts; delivery acceptance and duplicate prevention are unchanged.
- Does this need documentation?
- [x] No. Internal CI diagnostics only.
Also updates the existing runner test double to accept the watchdog argument and mocks its head poll, keeping that test offline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ci) Preserve failed review submission diagnostics [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen merged PR #69154:
URL: https://github.com/apache/doris/pull/69154
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ci) Preserve failed review submission diagnostics [doris]
Posted by "shuke987 (via GitHub)" <gi...@apache.org>.
shuke987 commented on PR #69154:
URL: https://github.com/apache/doris/pull/69154#issuecomment-6213501868
skip buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ci) Preserve failed review submission diagnostics [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69154:
URL: https://github.com/apache/doris/pull/69154#issuecomment-6206622050
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://doris.apache.org/community/how-to-contribute/review-and-ci).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org