You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "jasperjiaguo (via GitHub)" <gi...@apache.org> on 2023/05/06 01:13:43 UTC
[GitHub] [pinot] jasperjiaguo opened a new pull request, #10729: Enhance the instrumentation for a corner case where the query doesn't go through DocIdSetOp
jasperjiaguo opened a new pull request, #10729:
URL: https://github.com/apache/pinot/pull/10729
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #10729: Enhance the instrumentation for a corner case where the query doesn't go through DocIdSetOp
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #10729:
URL: https://github.com/apache/pinot/pull/10729#issuecomment-1536975813
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10729?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#10729](https://app.codecov.io/gh/apache/pinot/pull/10729?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c9795ad) into [master](https://app.codecov.io/gh/apache/pinot/commit/c47e7e55ce1713a0e63e1eb75c26ca9e23192f3f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c47e7e5) will **decrease** coverage by `54.71%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #10729 +/- ##
=============================================
- Coverage 68.53% 13.82% -54.71%
+ Complexity 6452 439 -6013
=============================================
Files 2122 2068 -54
Lines 114285 111803 -2482
Branches 17253 16955 -298
=============================================
- Hits 78322 15458 -62864
- Misses 30401 95082 +64681
+ Partials 5562 1263 -4299
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `?` | |
| unittests1 | `?` | |
| unittests2 | `13.82% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/pinot/pull/10729?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...perator/query/DictionaryBasedDistinctOperator.java](https://app.codecov.io/gh/apache/pinot/pull/10729?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9xdWVyeS9EaWN0aW9uYXJ5QmFzZWREaXN0aW5jdE9wZXJhdG9yLmphdmE=) | `0.00% <0.00%> (-76.09%)` | :arrow_down: |
... and [1635 files with indirect coverage changes](https://app.codecov.io/gh/apache/pinot/pull/10729/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] siddharthteotia commented on a diff in pull request #10729: Enhance the instrumentation for a corner case where the query doesn't go through DocIdSetOp
Posted by "siddharthteotia (via GitHub)" <gi...@apache.org>.
siddharthteotia commented on code in PR #10729:
URL: https://github.com/apache/pinot/pull/10729#discussion_r1188039034
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/query/DictionaryBasedDistinctOperator.java:
##########
@@ -134,6 +128,20 @@ private DistinctTable buildResult() {
return new DistinctTable(dataSchema, records, _nullHandlingEnabled);
}
+ private void iterateOnDictionary(int dictLength, int actualLimit, List<Record> records, boolean isAscending) {
+ if (isAscending) {
Review Comment:
(nit) I suggest separating this method into 2 to avoid doing the `if (_isAscending)` branch twice
cc @jasperjiaguo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] siddharthteotia merged pull request #10729: Enhance the instrumentation for a corner case where the query doesn't go through DocIdSetOp
Posted by "siddharthteotia (via GitHub)" <gi...@apache.org>.
siddharthteotia merged PR #10729:
URL: https://github.com/apache/pinot/pull/10729
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] jasperjiaguo commented on a diff in pull request #10729: Enhance the instrumentation for a corner case where the query doesn't go through DocIdSetOp
Posted by "jasperjiaguo (via GitHub)" <gi...@apache.org>.
jasperjiaguo commented on code in PR #10729:
URL: https://github.com/apache/pinot/pull/10729#discussion_r1188050090
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/query/DictionaryBasedDistinctOperator.java:
##########
@@ -134,6 +128,20 @@ private DistinctTable buildResult() {
return new DistinctTable(dataSchema, records, _nullHandlingEnabled);
}
+ private void iterateOnDictionary(int dictLength, int actualLimit, List<Record> records, boolean isAscending) {
+ if (isAscending) {
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org