You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/10/18 17:34:22 UTC
[GitHub] [tvm] mbrookhart opened a new pull request #9310: [Support] Move libinfo into the runtime build
mbrookhart opened a new pull request #9310:
URL: https://github.com/apache/tvm/pull/9310
@junrushao1994
We ran into some situations where it would be really nice to have lib information with runtime-only builds. Since we always build the runtime when we build the core tvm target, I figured this was a safe switch. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbrookhart commented on pull request #9310: [Support] Add libinfo into the runtime build
Posted by GitBox <gi...@apache.org>.
mbrookhart commented on pull request #9310:
URL: https://github.com/apache/tvm/pull/9310#issuecomment-946077530
Because only one of libtvm and libtvm_runtime is ever dlopened at a time, we need libinfo in both.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #9310: [Support] Move libinfo into the runtime build
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #9310:
URL: https://github.com/apache/tvm/pull/9310#issuecomment-946004276
Thanks @mbrookhart! BTW, do we want to move libinfo.cc to somewhere under the runtime folder?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #9310: [Support] Move libinfo into the runtime build
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #9310:
URL: https://github.com/apache/tvm/pull/9310#issuecomment-946010719
Got it. Then it looks good to me :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbrookhart merged pull request #9310: [Support] Add libinfo into the runtime build
Posted by GitBox <gi...@apache.org>.
mbrookhart merged pull request #9310:
URL: https://github.com/apache/tvm/pull/9310
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbrookhart commented on pull request #9310: [Support] Move libinfo into the runtime build
Posted by GitBox <gi...@apache.org>.
mbrookhart commented on pull request #9310:
URL: https://github.com/apache/tvm/pull/9310#issuecomment-946006355
We treat it as a separate object in cmake and extract it from the source tree at build time. Given the special treatment, I think support is a reasonable place?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbrookhart commented on pull request #9310: [Support] Move libinfo into the runtime build
Posted by GitBox <gi...@apache.org>.
mbrookhart commented on pull request #9310:
URL: https://github.com/apache/tvm/pull/9310#issuecomment-946051147
It looks like I broke something, let me figure out how
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org