[GitHub] [incubator-superset] graceguo-supercat edited a comment on pull request #9817: fix: [explore view] inline edit slice name should not overwrite

[GitBox <gi...@apache.org>]

graceguo-supercat edited a comment on pull request #9817:
URL: https://github.com/apache/incubator-superset/pull/9817#issuecomment-630371062


   The old implementation can save new chart when user give `untitled` new chart a title. But I feel this behavior is also confusing:
   - when try to auto save `untitled` chart, do we save chart title only, or should also save chart's query parameter,
   - when user keep exploring this new chart and changed control, do they know they need to save again?
   
   I feel the quick save behavior might bring more confusion than convenience, so i would like to keep a consistent behavior: _**nothing will be saved until user clicks save button**_.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org