You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/02 12:37:51 UTC
[GitHub] [airflow] dclandau opened a new pull request, #25469: Fix BaseSQLToGCSOperator approx_max_file_size_bytes
dclandau opened a new pull request, #25469:
URL: https://github.com/apache/airflow/pull/25469
When using the parquet file_format, using `tmp_file_handle.tell()`
always points to the beginning of the file after the data has been saved
and therefore is not a good indicator for the files current size.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #25313
related: #25313
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dclandau commented on pull request #25469: Fix BaseSQLToGCSOperator approx_max_file_size_bytes
Posted by GitBox <gi...@apache.org>.
dclandau commented on PR #25469:
URL: https://github.com/apache/airflow/pull/25469#issuecomment-1203291083
The tests were failing because when writing bytes into the file, python buffers the data until it is flushed via the method `fp.flush()`.
Because the file was not being flushed prior to the if statement, `os.stat(fp.name).st_size` was only indicating the size of the file as is in the system, without including the bytes still to be flushed.
As a quick sanity test you can run:
```python
with open('test', 'wb') as f:
f.write(b'hello')
print(f.tell())
import os
print(os.stat(f.name).st_size)
f.seek(0, os.SEEK_END)
print(f.tell())
f.flush()
print(os.stat(f.name).st_size)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #25469: Fix BaseSQLToGCSOperator approx_max_file_size_bytes
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #25469:
URL: https://github.com/apache/airflow/pull/25469
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #25469: Fix BaseSQLToGCSOperator approx_max_file_size_bytes
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #25469:
URL: https://github.com/apache/airflow/pull/25469#issuecomment-1202441684
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dclandau commented on pull request #25469: Fix BaseSQLToGCSOperator approx_max_file_size_bytes
Posted by GitBox <gi...@apache.org>.
dclandau commented on PR #25469:
URL: https://github.com/apache/airflow/pull/25469#issuecomment-1203250298
I'll have a look at it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25469: Fix BaseSQLToGCSOperator approx_max_file_size_bytes
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25469:
URL: https://github.com/apache/airflow/pull/25469#issuecomment-1203165983
Nice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25469: Fix BaseSQLToGCSOperator approx_max_file_size_bytes
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25469:
URL: https://github.com/apache/airflow/pull/25469#issuecomment-1203521948
Yeah. Tests are useful it seems :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #25469: Fix BaseSQLToGCSOperator approx_max_file_size_bytes
Posted by GitBox <gi...@apache.org>.
eladkal commented on PR #25469:
URL: https://github.com/apache/airflow/pull/25469#issuecomment-1203232700
Tests are failing :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org