You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/04/10 19:00:01 UTC
[GitHub] marcoabreu commented on a change in pull request #10485:
[MXNET-304][RFC] Jenkins docs build
marcoabreu commented on a change in pull request #10485: [MXNET-304][RFC] Jenkins docs build
URL: https://github.com/apache/incubator-mxnet/pull/10485#discussion_r180533790
##########
File path: ci/docker/install/ubuntu_docs.sh
##########
@@ -21,8 +21,44 @@
# the whole docker cache for the image
set -ex
-wget http://downloads.lightbend.com/scala/2.11.8/scala-2.11.8.deb && \
- dpkg -i scala-2.11.8.deb && rm scala-2.11.8.deb
+# Install dependencies
+echo 'Installing dependencies...'
+apt-get install -y \
+ apt-transport-https \
+ build-essential \
+ ca-certificates \
+ curl \
+ doxygen \
+ git \
+ libatlas-base-dev \
Review comment:
Are all these dependencies really required? Installing them here might override other version restrictions. It would be better to run this script after the other install scripts and then see what's actually required for the document generation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services