[jira] [Commented] (OAK-9770) incorrect annotation on AbstractLoginModule

["Angela Schreiber (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-9770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538027#comment-17538027 ] 

Angela Schreiber commented on OAK-9770:
---------------------------------------

[~reusr1], {{AbstractLoginModule}} is not part of _oak-auth-external_. I adjusted the component and also the severity.

given that plenty of crucial interfaces in _oak-security-spi_ are defined as Providertype (e.g. {{SecurityConfiguration}}, i am tempted to resolve this as works as designed (see also comments in OAK-6035).

also i don't the impact as dramatic because there is no requirement to extend from {{AbstractLoginModule}} as the JAAS setup looks for {{javax.security.auth.spi.LoginModule}}.

> incorrect annotation on AbstractLoginModule
> -------------------------------------------
>
>                 Key: OAK-9770
>                 URL: https://issues.apache.org/jira/browse/OAK-9770
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: security-spi
>            Reporter: Ruben Reusser
>            Priority: Blocker
>
> AbstractLoginModule is incorrectly annotated with @ProviderType [1] as the documentation in [0] describes the class as the basic extension point for authentication and even provides an example. This is causing a backwards compatibility issue in an upstream product due to code quality scans.
> [0] https://jackrabbit.apache.org/oak/docs/security/authentication.html
> [1]https://jackrabbit.apache.org/oak/docs/apidocs/org/apache/jackrabbit/oak/spi/security/authentication/AbstractLoginModule.html



--
This message was sent by Atlassian Jira
(v8.20.7#820007)