You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2023/01/13 11:09:44 UTC
[GitHub] [camel] simon-ras opened a new pull request, #9086: CAMEL-18912: Reuse client from consumer
simon-ras opened a new pull request, #9086:
URL: https://github.com/apache/camel/pull/9086
Before this change, autowired clients would fail to be detected.
Also small optimization added by only requesting a single queue when listing the queues.
# Target
- [x] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
# Tracking
- [x] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
<!--
# *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes.
-->
# Apache Camel coding standards and style
- [x] I checked that each commit in the pull request has a meaningful subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
-->
- [x] I formatted the code using `mvn -Pformat,fastinstall install && mvn -Psourcecheck`
<!--
You can run the aforementioned command in your module so that the build auto-formats your code and the source check verifies that is complies with our coding style. This will also be verified as part of the checks and your PR may be rejected if the checkstyle does not pass.
You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] simon-ras commented on pull request #9086: CAMEL-18912: Reuse client from consumer
Posted by GitBox <gi...@apache.org>.
simon-ras commented on PR #9086:
URL: https://github.com/apache/camel/pull/9086#issuecomment-1382062063
Forgot to format prior to pushing. Will reformat and push again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #9086: CAMEL-18912: Reuse client from consumer
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9086:
URL: https://github.com/apache/camel/pull/9086#issuecomment-1382129185
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 12 | 12 | 12 | 0 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #9086: CAMEL-18912: Reuse client from consumer
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9086:
URL: https://github.com/apache/camel/pull/9086#issuecomment-1382820784
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 12 | 12 | 0 | 12 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #9086: CAMEL-18912: Reuse client from consumer
Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #9086:
URL: https://github.com/apache/camel/pull/9086#issuecomment-1381841693
we will backport
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #9086: CAMEL-18912: Reuse client from consumer
Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #9086:
URL: https://github.com/apache/camel/pull/9086#issuecomment-1382865568
@simon-ras can we cherry pick this commit to camel-3.x or would you be able to do another PR for that branch so we get this into 3.x releases too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] simon-ras commented on pull request #9086: CAMEL-18912: Reuse client from consumer
Posted by GitBox <gi...@apache.org>.
simon-ras commented on PR #9086:
URL: https://github.com/apache/camel/pull/9086#issuecomment-1381807852
I can give it a shot - though it might take a few days due to limited spare time.
* Do you prefer 1 PR per component fixed, or 1 commit per component, or just a single commit including everything?
* Also, what is the best procedure for backporting this - should I make available PR with cherry-picked commit for each version, or better let you take care of this when merging the `main` PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] simon-ras commented on pull request #9086: CAMEL-18912: Reuse client from consumer
Posted by GitBox <gi...@apache.org>.
simon-ras commented on PR #9086:
URL: https://github.com/apache/camel/pull/9086#issuecomment-1382176346
I believe `AWS2S3ConsumerHealthCustomClientTest` - which is the failing test - is invalid. These tests all use the client which is set on the `configuration` and since the healthcheck now uses the client of the endpoint, then such case cannot be tested.
Do you mind @oscerd do you agree?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #9086: CAMEL-18912: Reuse client from consumer
Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #9086:
URL: https://github.com/apache/camel/pull/9086#issuecomment-1381795355
@simon-ras I wonder if you have time to check the other health checks in the AWS as they may also benefit from reusing client
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #9086: CAMEL-18912: Reuse client from consumer
Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #9086:
URL: https://github.com/apache/camel/pull/9086#issuecomment-1382078180
Thanks @simon-ras so this is fixes for all of camel-aws ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #9086: CAMEL-18912: Reuse client from consumer
Posted by GitBox <gi...@apache.org>.
oscerd commented on PR #9086:
URL: https://github.com/apache/camel/pull/9086#issuecomment-1382188353
It's important to make it works in all the cases. I think your fix will work only in case of client set on endpoint.. what happens if I specify keys secret and access? It should work too..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #9086: CAMEL-18912: Reuse client from consumer
Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #9086:
URL: https://github.com/apache/camel/pull/9086#issuecomment-1381841363
1 per component as if you do not get time to complete them all then others can take over later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #9086: CAMEL-18912: Reuse client from consumer
Posted by GitBox <gi...@apache.org>.
oscerd commented on PR #9086:
URL: https://github.com/apache/camel/pull/9086#issuecomment-1381842480
Don't worry about the backport operations, we'll do it. Thanks for your time and for reporting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #9086: CAMEL-18912: Reuse client from consumer
Posted by GitBox <gi...@apache.org>.
oscerd commented on PR #9086:
URL: https://github.com/apache/camel/pull/9086#issuecomment-1382194370
Ah right. You're right Simon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #9086: CAMEL-18912: Reuse client from consumer
Posted by GitBox <gi...@apache.org>.
davsclaus merged PR #9086:
URL: https://github.com/apache/camel/pull/9086
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #9086: CAMEL-18912: Reuse client from consumer
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9086:
URL: https://github.com/apache/camel/pull/9086#issuecomment-1382156960
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 12 | 12 | 1 | 11 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] simon-ras commented on pull request #9086: CAMEL-18912: Reuse client from consumer
Posted by GitBox <gi...@apache.org>.
simon-ras commented on PR #9086:
URL: https://github.com/apache/camel/pull/9086#issuecomment-1382091130
Yes, for all health checks. There is still a few components which does not have health checks, they are listed here https://issues.apache.org/jira/browse/CAMEL-18131. They continue to use ComponentVerifierExtension.
I just discovered that there are some test which fail though, so this PR is not quite ready yet...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #9086: CAMEL-18912: Reuse client from consumer
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9086:
URL: https://github.com/apache/camel/pull/9086#issuecomment-1382818800
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 12 | 12 | 1 | 11 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] simon-ras commented on pull request #9086: CAMEL-18912: Reuse client from consumer
Posted by GitBox <gi...@apache.org>.
simon-ras commented on PR #9086:
URL: https://github.com/apache/camel/pull/9086#issuecomment-1382905059
> @simon-ras can we cherry pick this commit to [camel-3](https://issues.apache.org/jira/browse/CAMEL-3).x or would you be able to do another PR for that branch so we get this into 3.x releases too
Sure, please see https://github.com/apache/camel/pull/9105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #9086: CAMEL-18912: Reuse client from consumer
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9086:
URL: https://github.com/apache/camel/pull/9086#issuecomment-1381694343
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:warning: Please note that the changes on this PR may be **tested automatically**.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org