You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by "Zhanwei Wang (JIRA)" <ji...@apache.org> on 2018/06/15 13:45:00 UTC

[jira] [Commented] (HAWQ-1624) Make libhdfs3 binary compatible with libhdfs

    [ https://issues.apache.org/jira/browse/HAWQ-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16513819#comment-16513819 ] 

Zhanwei Wang commented on HAWQ-1624:
------------------------------------

hdfsPread cannot be implemented efficiently, that is why it is not in libhdfs3. For the ABI compatible reason, it is OK to me to implement it with seek and read. 

For API hdfsSync hdfsHSync hdfsFlush and hdfsHFlush, Maybe I cannot remember correctly but when I wrote that code, libhdfs3 did the same thing with libhdfs. But things changed after time. I guess it is time to make them the same again.

HAWQ only depends on HdfsSync to sync data to disk. So It is to me to make this change.

> Make libhdfs3 binary compatible with libhdfs
> --------------------------------------------
>
>                 Key: HAWQ-1624
>                 URL: https://issues.apache.org/jira/browse/HAWQ-1624
>             Project: Apache HAWQ
>          Issue Type: Improvement
>          Components: libhdfs
>            Reporter: Sergei Lebedev
>            Assignee: Radar Lei
>            Priority: Minor
>
> libhdfs3 is almost binary compatible with libhdfs. The missing bits are:
> * libhdfs3 does not define hdfsPread which nonetheless can be implemented in terms of hdfsTell, hdfsSeek and hdfsRead;
> * hdfsSync is called hdfsHSync in libhdfs3;
> * In libhdfs hdfsFlush flushes the internal buffer of the BufferedInputStream; in libhdfs3 it always flushes to HDFS, i.e. it does what hdfsHFlush should do. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)