You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Jim Jagielski <ji...@jaguNET.com> on 2000/01/10 13:30:43 UTC
Re: cvs commit: apache-1.3/src Configure
martin@hyperreal.org wrote:
>
> --- Configure 1999/12/20 14:50:55 1.383
> +++ Configure 2000/01/10 10:39:46 1.384
> @@ -1484,6 +1484,12 @@
> fi
> ;;
> BS2000*-siemens-sysv4*)
> + # Activate RISC compilation if this is a SR2000 machine
> + # (test written by Thomas Dorner <Th...@start.de>
> + # for perl5 port):
> + if [ -n "`bs2cmd SHOW-SYSTEM-INFO | grep 'HSI-ATT.*TYPE.*SR'`" ]; then
> + CFLAGS="$CFLAGS -Krisc_4000"
> + fi
> # Depending on the BS2000 OS and compiler/crte release,
> # -lnsl may be available (or may be not).
> # In standard SVR4 systems, -lsocket relies on some symbols
I don't think we use this construct anyplace else... Being so
close to 1.3.10, this makes me a little nervous :)
Is it OK if I switch that to:
ISSR2000="`bs2cmd SHOW-SYSTEM-INFO | grep 'HSI-ATT.*TYPE.*SR'`"
case "$ISSR2000" in
*HSI-ATT.*TYPE.*SR*)
CFLAGS="$CFLAGS -Krisc_4000"
;;
esac
Yeah, it's ugly, but we've used that before.
PS: Not sure what the output is of bs2cmd SHOW-SYSTEM-INFO but we
could drop that grep as well I'm thinking, unless it's multi-line
in which case the grep kinda makes sense.
--
===========================================================================
Jim Jagielski [|] jim@jaguNET.com [|] http://www.jaguNET.com/
"Are you suggesting coconuts migrate??"
Re: cvs commit: apache-1.3/src Configure
Posted by Martin Kraemer <Ma...@Mch.SNI.De>.
On Mon, Jan 10, 2000 at 07:30:43AM -0500, Jim Jagielski wrote:
> I don't think we use this construct anyplace else... Being so
> close to 1.3.10, this makes me a little nervous :)
It's alright (this branch is really only executed on BS2000).
> Is it OK if I switch that to:
>
> ISSR2000="`bs2cmd SHOW-SYSTEM-INFO | grep 'HSI-ATT.*TYPE.*SR'`"
> case "$ISSR2000" in
> *HSI-ATT.*TYPE.*SR*)
> CFLAGS="$CFLAGS -Krisc_4000"
> ;;
> esac
Yes, would be fine with me just as well. I simply copied over the other
"if" from perl and did not think of the test [ -n ... ], sorry.
> PS: Not sure what the output is of bs2cmd SHOW-SYSTEM-INFO but we
> could drop that grep as well I'm thinking, unless it's multi-line
> in which case the grep kinda makes sense.
Yes, it's about 20 lines.
But: good point (I dislike the heavy use of grep too).
Change as you feel fit. But to the best of my knowledge ;-) this shouldn't
have hurt any other platform.
Martin
--
<Ma...@MchP.Siemens.De> | Fujitsu Siemens
<ma...@apache.org> | 81730 Munich, Germany