You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/02/16 07:15:41 UTC
[GitHub] [rocketmq] kexianjun opened a new issue #1777: Question about
org.apache.rocketmq.store.MappedFile#destroy
kexianjun opened a new issue #1777: Question about org.apache.rocketmq.store.MappedFile#destroy
URL: https://github.com/apache/rocketmq/issues/1777
When transientStorePoolEnable is set to true,the MappedFile may borrow Buffer from TransientStorePool and assigned it to writeBuffer,but when a MappedFile is destroied,the writeBuffer is not returned to TransientStorePool,is it necessary?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] RongtongJin commented on issue #1777: Question about
org.apache.rocketmq.store.MappedFile#destroy
Posted by GitBox <gi...@apache.org>.
RongtongJin commented on issue #1777: Question about org.apache.rocketmq.store.MappedFile#destroy
URL: https://github.com/apache/rocketmq/issues/1777#issuecomment-586907738
It is not necessary to return writeBuffer. MappedFile reepresents the file on disk , writeBuffer in TransientStorePool is direct buffer to temporary writing, when all the content in writeBuffer commit to file, the writterBuffer will be returned (org.apache.rocketmq.store.MappedFile#commit). So when MappedFile is destroyed, the writeBuffer should already be returned.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] RongtongJin closed issue #1777: Question about
org.apache.rocketmq.store.MappedFile#destroy
Posted by GitBox <gi...@apache.org>.
RongtongJin closed issue #1777: Question about org.apache.rocketmq.store.MappedFile#destroy
URL: https://github.com/apache/rocketmq/issues/1777
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services