Re: [PR] [fix](cloud) release fd after clear file cache [doris]

["gavinchou (via GitHub)" <gi...@apache.org>]

gavinchou commented on code in PR #50555:
URL: https://github.com/apache/doris/pull/50555#discussion_r2072505625


##########
be/src/io/cache/block_file_cache.cpp:
##########
@@ -2077,6 +2077,17 @@ std::string BlockFileCache::clear_file_cache_directly() {
     int64_t normal_queue_size = _normal_queue.get_elements_num(cache_lock);
     int64_t disposible_queue_size = _disposable_queue.get_elements_num(cache_lock);
     int64_t ttl_queue_size = _ttl_queue.get_elements_num(cache_lock);
+
+    if (config::clear_fd_after_clear_file_cache) {

Review Comment:
   it seems there is no performance problem, line 2069 `auto s = _storage->clear(clear_msg);` is blocking and time-consuming job before removing FDs.
   to avoid too many knobs, keep it simple if the behavior is determined.
   we have too many knobs for file cache, too many.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org