You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/08/04 15:34:23 UTC
[PR] Reset Snowflake time service after each test [shardingsphere]
terrymanu opened a new pull request, #39337:
URL: https://github.com/apache/shardingsphere/pull/39337
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Reset Snowflake time service after each test [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #39337:
URL: https://github.com/apache/shardingsphere/pull/39337#issuecomment-5181291269
### Result
**Review Result: Mergeable**
The test-only change correctly resets the static `TimeService` after each test, preventing fixed-time test state from leaking into later tests.
### Evidence
- PR head `d0d5729`, one changed test file: [PR diff](https://github.com/apache/shardingsphere/pull/39337/files)
- Focused test passed: 12 tests, 0 failures, 0 errors.
- `TimeService` is static production state; the added `@AfterEach` restores the real implementation.
### Coverage
- Reviewed head: `d0d5729285d`
- Scope: 1 authoritative changed file.
- Clusters: test isolation and static-state cleanup.
- Checked root-cause behavior, blast radius/contracts, and test validity.
- Code-scope result only; CI was not reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Reset Snowflake time service after each test [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #39337:
URL: https://github.com/apache/shardingsphere/pull/39337
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org