[GitHub] [sling-slingfeature-maven-plugin] cziegeler commented on issue #35: Created a Feature Launcher Mojo (launch-features)

[GitBox <gi...@apache.org>]

cziegeler commented on issue #35: Created a Feature Launcher Mojo (launch-features)
URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/35#issuecomment-521925894
 
 
   When it comes to feature selection, I think this mojo should support the same options as all the other mojos: you can either select a file, a maven dependency, classifiers etc.
   As a parameter you can simply use a FeatureSelectionConfig and inherit from AbstractIncludingFeatureMojo to get most of the logic you need for this.
   This way we maintain a consistent way of configuring the mojos.
   We could also think about making it possible to launch several instances, probably based on different features. In that case a configuration style like the analyser or aggregate mojo use is more appropriate. But again, that's based on a subclass of FeatureSelectionConfig and extending AbstractIncludingFeatureMojo  as well
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services