You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2017/08/29 00:14:35 UTC
[kudu-CR] [release notes] add new kudu tool features and metrics improvements
Hello Will Berkeley,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/7865
to review the following change.
Change subject: [release notes] add new kudu tool features and metrics improvements
......................................................................
[release notes] add new kudu tool features and metrics improvements
Change-Id: Ic9514999a913c52fdfc9ed3cf6a85da50b190c68
---
M docs/release_notes.adoc
1 file changed, 16 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/65/7865/1
--
To view, visit http://gerrit.cloudera.org:8080/7865
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic9514999a913c52fdfc9ed3cf6a85da50b190c68
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [release notes] add new kudu tool features and metrics improvements
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [release notes] add new kudu tool features and metrics improvements
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7865/2/docs/release_notes.adoc
File docs/release_notes.adoc:
PS2, Line 83: kudu
Surround in backticks.
PS2, Line 105: Previously, the
: metric counted only the base data and REDO deltas; it now counts all deltas.
Maybe "Previously, the metric included only REDO deltas; it now includes all deltas."
That doesn't give you the sum total of what the metric includes (i.e. the base data) but it does a clearer job of explaining the transition from REDO to REDO+UNDO.
--
To view, visit http://gerrit.cloudera.org:8080/7865
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9514999a913c52fdfc9ed3cf6a85da50b190c68
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes
[kudu-CR] [release notes] add new kudu tool features and metrics improvements
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [release notes] add new kudu tool features and metrics improvements
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7865/2/docs/release_notes.adoc
File docs/release_notes.adoc:
PS2, Line 83: kudu
> Surround in backticks.
Done
PS2, Line 105: Previously, the
: metric counted only the base data and REDO deltas; it now counts all deltas.
> Maybe "Previously, the metric included only REDO deltas; it now includes al
Done
--
To view, visit http://gerrit.cloudera.org:8080/7865
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9514999a913c52fdfc9ed3cf6a85da50b190c68
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes
[kudu-CR] [release notes] add new kudu tool features and metrics improvements
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7865
to look at the new patch set (#3).
Change subject: [release notes] add new kudu tool features and metrics improvements
......................................................................
[release notes] add new kudu tool features and metrics improvements
Change-Id: Ic9514999a913c52fdfc9ed3cf6a85da50b190c68
---
M docs/release_notes.adoc
1 file changed, 16 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/65/7865/3
--
To view, visit http://gerrit.cloudera.org:8080/7865
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic9514999a913c52fdfc9ed3cf6a85da50b190c68
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [release notes] add new kudu tool features and metrics improvements
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.
Change subject: [release notes] add new kudu tool features and metrics improvements
......................................................................
[release notes] add new kudu tool features and metrics improvements
Change-Id: Ic9514999a913c52fdfc9ed3cf6a85da50b190c68
Reviewed-on: http://gerrit.cloudera.org:8080/7865
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Will Berkeley <wd...@gmail.com>
Tested-by: Dan Burkert <da...@apache.org>
---
M docs/release_notes.adoc
1 file changed, 16 insertions(+), 0 deletions(-)
Approvals:
Dan Burkert: Verified
Adar Dembo: Looks good to me, approved
Will Berkeley: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.cloudera.org:8080/7865
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9514999a913c52fdfc9ed3cf6a85da50b190c68
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [release notes] add new kudu tool features and metrics improvements
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [release notes] add new kudu tool features and metrics improvements
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7865
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9514999a913c52fdfc9ed3cf6a85da50b190c68
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No
[kudu-CR] [release notes] add new kudu tool features and metrics improvements
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has uploaded a new patch set (#2).
Change subject: [release notes] add new kudu tool features and metrics improvements
......................................................................
[release notes] add new kudu tool features and metrics improvements
Change-Id: Ic9514999a913c52fdfc9ed3cf6a85da50b190c68
---
M docs/release_notes.adoc
1 file changed, 16 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/65/7865/2
--
To view, visit http://gerrit.cloudera.org:8080/7865
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic9514999a913c52fdfc9ed3cf6a85da50b190c68
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [release notes] add new kudu tool features and metrics improvements
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [release notes] add new kudu tool features and metrics improvements
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7865
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9514999a913c52fdfc9ed3cf6a85da50b190c68
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No
[kudu-CR] [release notes] add new kudu tool features and metrics improvements
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change.
Change subject: [release notes] add new kudu tool features and metrics improvements
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/7865
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9514999a913c52fdfc9ed3cf6a85da50b190c68
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No