[jira] [Commented] (STORM-843) [storm-redis] Add Javadoc to storm-redis

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14585310#comment-14585310 ] 

ASF GitHub Bot commented on STORM-843:
--------------------------------------

GitHub user HeartSaVioR opened a pull request:

    https://github.com/apache/storm/pull/594

    STORM-843 Add Javadoc to storm-redis

    * leaves javadoc for Trident API : it should be treated from Trident API
    * some code cleanup

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/HeartSaVioR/storm STORM-843

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/594.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #594
    
----
commit 8d05605868421f58096def9119bd8e5db7de24e9
Author: Jungtaek Lim <ka...@gmail.com>
Date:   2015-06-14T23:14:11Z

    STORM-843 Add Javadoc to storm-redis
    
    * leaves javadoc for Trident API : it should be treated from Trident API
    * some code cleanup

----


> [storm-redis] Add Javadoc to storm-redis
> ----------------------------------------
>
>                 Key: STORM-843
>                 URL: https://issues.apache.org/jira/browse/STORM-843
>             Project: Apache Storm
>          Issue Type: Improvement
>            Reporter: Jungtaek Lim
>
> Since storm-redis doesn't have Javadoc, users have to rely on README and unit tests (actually twos are same)
> It would be great to have it, since we can get a change to give users to understand what this method/class means.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)