You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "Yicong-Huang (via GitHub)" <gi...@apache.org> on 2025/11/26 20:49:16 UTC
[PR] Spark 53597/docs/add astable examples [spark]
Yicong-Huang opened a new pull request, #53240:
URL: https://github.com/apache/spark/pull/53240
### Why are the changes needed?
There are no examples showing how to use `DataFrame.asTable()` and `TableArg` features. These examples are essential for users to understand how to:
- Convert DataFrames to table arguments for use in TVFs/UDTFs
- Control data partitioning and ordering when passing DataFrames as table arguments
- Use the various methods available on `TableArg` instances
### Does this PR introduce _any_ user-facing change?
Yes, this is a documentation-only change that adds examples to the public API documentation. No functional changes are introduced.
### How was this patch tested?
The examples follow the same patterns used in existing test cases (`test_udtf.py`). The examples are written in doctest format and should be validated when running doctests.
### Was this patch authored or co-authored using generative AI tooling?
Co-Generated-by: Cursor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53597][PYTHON][SQL][DOCS] Add `asTable()` and `TableArg` examples [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #53240:
URL: https://github.com/apache/spark/pull/53240#issuecomment-3583992281
Late LGTM, but I think we don't need `[SQL]` in the title @Yicong-Huang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53597][PYTHON][SQL][DOCS] Add `asTable()` and `TableArg` examples [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #53240: [SPARK-53597][PYTHON][SQL][DOCS] Add `asTable()` and `TableArg` examples
URL: https://github.com/apache/spark/pull/53240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53597][PYTHON][SQL][DOCS] Add `asTable()` and `TableArg` examples [spark]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on PR #53240:
URL: https://github.com/apache/spark/pull/53240#issuecomment-3584277972
> Late LGTM, but I think we don't need `[SQL]` in the title @Yicong-Huang
Got it. Will be careful next time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org