You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Dan Dumont <dd...@us.ibm.com> on 2012/04/10 22:35:22 UTC
Review Request: Separate out the different open* APIs into their own
features so they can easily be enabled/disabled
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4693/
-----------------------------------------------------------
Review request for shindig.
Summary
-------
Broke features apart into smaller features.
Updated mixin function in common container to allow you to mix several of the same namespace in.
This addresses bug SHINDIG-1721.
https://issues.apache.org/jira/browse/SHINDIG-1721
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1311965
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1311965
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1311965
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/feature.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/open-views-common-container.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/open-views-common-gadget.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/feature.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-container.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-gadget.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.gadget/feature.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.gadget/open-views-gadget-container.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.gadget/open-views-gadget-gadget.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.results/feature.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.results/open-views-results-container.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.results/open-views-results-gadget.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.url/feature.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.url/open-views-url-container.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.url/open-views-url-gadget.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/feature.xml 1311965
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js 1311965
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements.js 1311965
Diff: https://reviews.apache.org/r/4693/diff
Testing
-------
All existing tests pass
Thanks,
Dan
Re: Review Request: Separate out the different open* APIs into their own
features so they can easily be enabled/disabled
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4693/#review6877
-----------------------------------------------------------
Ship it!
Committed r1325259
- Dan
On 2012-04-11 14:57:33, Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4693/
> -----------------------------------------------------------
>
> (Updated 2012-04-11 14:57:33)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> Broke features apart into smaller features.
>
> Updated mixin function in common container to allow you to mix several of the same namespace in.
>
>
> This addresses bug SHINDIG-1721.
> https://issues.apache.org/jira/browse/SHINDIG-1721
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1311965
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1311965
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1311965
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/open-views-common-container.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/open-views-common-gadget.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-container.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-gadget.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.gadget/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.gadget/open-views-gadget-container.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.gadget/open-views-gadget-gadget.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.results/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.results/open-views-results-container.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.results/open-views-results-gadget.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.url/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.url/open-views-url-container.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.url/open-views-url-gadget.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/feature.xml 1311965
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js 1311965
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements.js 1311965
>
> Diff: https://reviews.apache.org/r/4693/diff
>
>
> Testing
> -------
>
> All existing tests pass
>
>
> Thanks,
>
> Dan
>
>
Re: Review Request: Separate out the different open* APIs into their own
features so they can easily be enabled/disabled
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4693/
-----------------------------------------------------------
(Updated 2012-04-11 14:57:33.421695)
Review request for shindig.
Changes
-------
Fixed comment.
Summary
-------
Broke features apart into smaller features.
Updated mixin function in common container to allow you to mix several of the same namespace in.
This addresses bug SHINDIG-1721.
https://issues.apache.org/jira/browse/SHINDIG-1721
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1311965
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1311965
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1311965
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/feature.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/open-views-common-container.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/open-views-common-gadget.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/feature.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-container.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-gadget.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.gadget/feature.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.gadget/open-views-gadget-container.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.gadget/open-views-gadget-gadget.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.results/feature.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.results/open-views-results-container.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.results/open-views-results-gadget.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.url/feature.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.url/open-views-url-container.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.url/open-views-url-gadget.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/feature.xml 1311965
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js 1311965
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements.js 1311965
Diff: https://reviews.apache.org/r/4693/diff
Testing
-------
All existing tests pass
Thanks,
Dan
Re: Review Request: Separate out the different open* APIs into their own
features so they can easily be enabled/disabled
Posted by Ryan Baxter <rb...@gmail.com>.
> On 2012-04-11 13:57:09, Ryan Baxter wrote:
> >
Forgot to say LGTM
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4693/#review6845
-----------------------------------------------------------
On 2012-04-11 12:51:08, Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4693/
> -----------------------------------------------------------
>
> (Updated 2012-04-11 12:51:08)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> Broke features apart into smaller features.
>
> Updated mixin function in common container to allow you to mix several of the same namespace in.
>
>
> This addresses bug SHINDIG-1721.
> https://issues.apache.org/jira/browse/SHINDIG-1721
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/open-views-common-container.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1311965
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1311965
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1311965
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/open-views-common-gadget.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-container.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-gadget.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.gadget/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.gadget/open-views-gadget-container.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.gadget/open-views-gadget-gadget.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.results/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.results/open-views-results-container.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.results/open-views-results-gadget.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.url/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.url/open-views-url-container.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.url/open-views-url-gadget.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/feature.xml 1311965
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js 1311965
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements.js 1311965
>
> Diff: https://reviews.apache.org/r/4693/diff
>
>
> Testing
> -------
>
> All existing tests pass
>
>
> Thanks,
>
> Dan
>
>
Re: Review Request: Separate out the different open* APIs into their own
features so they can easily be enabled/disabled
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4693/#review6845
-----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.results/open-views-results-container.js
<https://reviews.apache.org/r/4693/#comment15238>
Could you just fix this comment :) I think it is actually my typo
- Ryan
On 2012-04-11 12:51:08, Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4693/
> -----------------------------------------------------------
>
> (Updated 2012-04-11 12:51:08)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> Broke features apart into smaller features.
>
> Updated mixin function in common container to allow you to mix several of the same namespace in.
>
>
> This addresses bug SHINDIG-1721.
> https://issues.apache.org/jira/browse/SHINDIG-1721
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/open-views-common-container.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1311965
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1311965
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1311965
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/open-views-common-gadget.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-container.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-gadget.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.gadget/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.gadget/open-views-gadget-container.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.gadget/open-views-gadget-gadget.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.results/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.results/open-views-results-container.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.results/open-views-results-gadget.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.url/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.url/open-views-url-container.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.url/open-views-url-gadget.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/feature.xml 1311965
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js 1311965
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements.js 1311965
>
> Diff: https://reviews.apache.org/r/4693/diff
>
>
> Testing
> -------
>
> All existing tests pass
>
>
> Thanks,
>
> Dan
>
>
Re: Review Request: Separate out the different open* APIs into their own
features so they can easily be enabled/disabled
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4693/
-----------------------------------------------------------
(Updated 2012-04-11 12:51:08.982077)
Review request for shindig.
Changes
-------
Removed leftover feature.xml declarations in open-views.common
Summary
-------
Broke features apart into smaller features.
Updated mixin function in common container to allow you to mix several of the same namespace in.
This addresses bug SHINDIG-1721.
https://issues.apache.org/jira/browse/SHINDIG-1721
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/open-views-common-container.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1311965
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/feature.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1311965
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1311965
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/open-views-common-gadget.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/feature.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-container.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-gadget.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.gadget/feature.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.gadget/open-views-gadget-container.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.gadget/open-views-gadget-gadget.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.results/feature.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.results/open-views-results-container.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.results/open-views-results-gadget.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.url/feature.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.url/open-views-url-container.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.url/open-views-url-gadget.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/feature.xml 1311965
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js 1311965
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements.js 1311965
Diff: https://reviews.apache.org/r/4693/diff
Testing
-------
All existing tests pass
Thanks,
Dan
Re: Review Request: Separate out the different open* APIs into their own
features so they can easily be enabled/disabled
Posted by Dan Dumont <dd...@us.ibm.com>.
> On 2012-04-11 11:20:18, Stanton Sievers wrote:
> > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.url/open-views-url-container.js, line 68
> > <https://reviews.apache.org/r/4693/diff/2/?file=101274#file101274line68>
> >
> > Whitespace
Oh those sneaky little whitespaces...
- Dan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4693/#review6838
-----------------------------------------------------------
On 2012-04-10 20:35:22, Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4693/
> -----------------------------------------------------------
>
> (Updated 2012-04-10 20:35:22)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> Broke features apart into smaller features.
>
> Updated mixin function in common container to allow you to mix several of the same namespace in.
>
>
> This addresses bug SHINDIG-1721.
> https://issues.apache.org/jira/browse/SHINDIG-1721
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1311965
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1311965
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1311965
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/open-views-common-container.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/open-views-common-gadget.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-container.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-gadget.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.gadget/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.gadget/open-views-gadget-container.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.gadget/open-views-gadget-gadget.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.results/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.results/open-views-results-container.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.results/open-views-results-gadget.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.url/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.url/open-views-url-container.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.url/open-views-url-gadget.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/feature.xml 1311965
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js 1311965
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements.js 1311965
>
> Diff: https://reviews.apache.org/r/4693/diff
>
>
> Testing
> -------
>
> All existing tests pass
>
>
> Thanks,
>
> Dan
>
>
Re: Review Request: Separate out the different open* APIs into their own
features so they can easily be enabled/disabled
Posted by Stanton Sievers <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4693/#review6838
-----------------------------------------------------------
Looks like some things were missed when pulling the results feature out. See inline comments.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/feature.xml
<https://reviews.apache.org/r/4693/#comment15229>
Why is this here? I thought this was part of the new results feature?
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/feature.xml
<https://reviews.apache.org/r/4693/#comment15230>
Same as setReturnValue above
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/feature.xml
<https://reviews.apache.org/r/4693/#comment15232>
I don't see this being used.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/feature.xml
<https://reviews.apache.org/r/4693/#comment15233>
I don't see this being used either.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/feature.xml
<https://reviews.apache.org/r/4693/#comment15231>
Same as setReturnValue above.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/feature.xml
<https://reviews.apache.org/r/4693/#comment15234>
This isn't being used.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.url/open-views-url-container.js
<https://reviews.apache.org/r/4693/#comment15228>
Whitespace
- Stanton
On 2012-04-10 20:35:22, Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4693/
> -----------------------------------------------------------
>
> (Updated 2012-04-10 20:35:22)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> Broke features apart into smaller features.
>
> Updated mixin function in common container to allow you to mix several of the same namespace in.
>
>
> This addresses bug SHINDIG-1721.
> https://issues.apache.org/jira/browse/SHINDIG-1721
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1311965
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1311965
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1311965
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/open-views-common-container.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/open-views-common-gadget.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-container.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-gadget.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.gadget/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.gadget/open-views-gadget-container.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.gadget/open-views-gadget-gadget.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.results/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.results/open-views-results-container.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.results/open-views-results-gadget.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.url/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.url/open-views-url-container.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.url/open-views-url-gadget.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/feature.xml 1311965
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js 1311965
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements.js 1311965
>
> Diff: https://reviews.apache.org/r/4693/diff
>
>
> Testing
> -------
>
> All existing tests pass
>
>
> Thanks,
>
> Dan
>
>