You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2021/01/25 19:39:08 UTC
[kudu-CR](branch-1.14.x) Add release notes for 1.14.0
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16980
Change subject: Add release notes for 1.14.0
......................................................................
Add release notes for 1.14.0
Change-Id: Ib8da030ce0f8797f8c366c56298fcda1020b00b6
---
M docs/release_notes.adoc
1 file changed, 172 insertions(+), 29 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/16980/1
--
To view, visit http://gerrit.cloudera.org:8080/16980
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.14.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib8da030ce0f8797f8c366c56298fcda1020b00b6
Gerrit-Change-Number: 16980
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR](branch-1.14.x) Add release notes for 1.14.0
Posted by "Greg Solovyev (Code Review)" <ge...@cloudera.org>.
Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/16980 )
Change subject: Add release notes for 1.14.0
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16980/2/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/16980/2/docs/release_notes.adoc@174
PS2, Line 174: * Fixed a heap-use-after-free bug in Kudu C++ client that might manifest itself when altering a
is there a Jira for this or any information on how this bug might manifest itself?
--
To view, visit http://gerrit.cloudera.org:8080/16980
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.14.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8da030ce0f8797f8c366c56298fcda1020b00b6
Gerrit-Change-Number: 16980
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Jan 2021 22:41:40 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.14.x) Add release notes for 1.14.0
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Greg Solovyev, Bankim Bhavsar,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16980
to look at the new patch set (#4).
Change subject: Add release notes for 1.14.0
......................................................................
Add release notes for 1.14.0
Change-Id: Ib8da030ce0f8797f8c366c56298fcda1020b00b6
---
M docs/release_notes.adoc
1 file changed, 185 insertions(+), 29 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/16980/4
--
To view, visit http://gerrit.cloudera.org:8080/16980
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.14.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib8da030ce0f8797f8c366c56298fcda1020b00b6
Gerrit-Change-Number: 16980
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR](branch-1.14.x) Add release notes for 1.14.0
Posted by "Greg Solovyev (Code Review)" <ge...@cloudera.org>.
Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/16980 )
Change subject: Add release notes for 1.14.0
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/16980
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.14.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8da030ce0f8797f8c366c56298fcda1020b00b6
Gerrit-Change-Number: 16980
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Jan 2021 18:46:37 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.14.x) Add release notes for 1.14.0
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16980 )
Change subject: Add release notes for 1.14.0
......................................................................
Patch Set 2:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/16980/2/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/16980/2/docs/release_notes.adoc@55
PS2, Line 55: [[rn_1.14.0_new_features]]
A few more worth considering:
[java] add method to deserialize scanner token into scanner builder https://github.com/apache/kudu/commit/d01145b982517dd7a5aa507543e6ffc1dfa1e584
The KuduScanToken Java API has been extended with a deserializeIntoScannerBuilder() method that can be used to further customize generated tokens.
KUDU-3012: Add a Log Throttler https://github.com/apache/kudu/commit/8fc3ce7040b485424d196e6f9032c7b22b43b122
Logging of the error message produced when applying an op while a Java KuduSession is closed has been throttled.
[tool] allow customizing parallelism for local_replica copy_from_remote https://github.com/apache/kudu/commit/0df4eaaa6590aabfc212c2faa5c73db00c9452fb
Users can now specify the level of parallelization when copying a tablet using the `kudu local_replica copy_from_remote` by passing the `--tablet_copy_download_threads_nums_per_session` argument.
http://gerrit.cloudera.org:8080/#/c/16980/2/docs/release_notes.adoc@94
PS2, Line 94: The HMS
: plugin will now check if the Kudu cluster associated with a table has HMS synchronization enabled.
Should this be a separate bullet?
http://gerrit.cloudera.org:8080/#/c/16980/2/docs/release_notes.adoc@119
PS2, Line 119: CatalogManager
nit: I thought we typically shied away from less user-facing names like this. Maybe just "Kudu Masters"?
http://gerrit.cloudera.org:8080/#/c/16980/2/docs/release_notes.adoc@139
PS2, Line 139: WrapSaslCall
nit: would it make sense to not refer to specific function names and instead call out when this happens? E.g. when first connecting to a server?
http://gerrit.cloudera.org:8080/#/c/16980/2/docs/release_notes.adoc@159
PS2, Line 159: maintenance manager
nit: we should probably standardize this. "MaintenanceManager", as it is elsewhere?
--
To view, visit http://gerrit.cloudera.org:8080/16980
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.14.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8da030ce0f8797f8c366c56298fcda1020b00b6
Gerrit-Change-Number: 16980
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Jan 2021 22:28:38 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.14.x) Add release notes for 1.14.0
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16980 )
Change subject: Add release notes for 1.14.0
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16980
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.14.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8da030ce0f8797f8c366c56298fcda1020b00b6
Gerrit-Change-Number: 16980
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Jan 2021 04:25:23 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.14.x) Add release notes for 1.14.0
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16980 )
Change subject: Add release notes for 1.14.0
......................................................................
Patch Set 2:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/16980/2/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/16980/2/docs/release_notes.adoc@38
PS2, Line 38: they are at or near end-of-life
This reads as Debian is also at EOL point, but I know there is Debian 10.7 released December 5 2020, and there is Debian 11 in preview.
Maybe, add a separate sentence to announce dropping support for Kudu on Debian?
http://gerrit.cloudera.org:8080/#/c/16980/2/docs/release_notes.adoc@71
PS2, Line 71: jars
nit: JARs ?
http://gerrit.cloudera.org:8080/#/c/16980/2/docs/release_notes.adoc@74
PS2, Line 74: Id
nit: identifier ?
http://gerrit.cloudera.org:8080/#/c/16980/2/docs/release_notes.adoc@119
PS2, Line 119: CatalogManager
> nit: I thought we typically shied away from less user-facing names like thi
+1: yes, I guess "Kudu Masters" is more user-friendly.
http://gerrit.cloudera.org:8080/#/c/16980/2/docs/release_notes.adoc@175
PS2, Line 175: a table
nit: the table ?
http://gerrit.cloudera.org:8080/#/c/16980/2/docs/release_notes.adoc@185
PS2, Line 185: jars
nit: JARs ?
--
To view, visit http://gerrit.cloudera.org:8080/16980
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.14.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8da030ce0f8797f8c366c56298fcda1020b00b6
Gerrit-Change-Number: 16980
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Jan 2021 03:43:14 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.14.x) Add release notes for 1.14.0
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Greg Solovyev, Bankim Bhavsar,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16980
to look at the new patch set (#2).
Change subject: Add release notes for 1.14.0
......................................................................
Add release notes for 1.14.0
Change-Id: Ib8da030ce0f8797f8c366c56298fcda1020b00b6
---
M docs/release_notes.adoc
1 file changed, 172 insertions(+), 29 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/16980/2
--
To view, visit http://gerrit.cloudera.org:8080/16980
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.14.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib8da030ce0f8797f8c366c56298fcda1020b00b6
Gerrit-Change-Number: 16980
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR](branch-1.14.x) Add release notes for 1.14.0
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16980 )
Change subject: Add release notes for 1.14.0
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16980/2/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/16980/2/docs/release_notes.adoc@174
PS2, Line 174: link:https://issues.apache.org/jira/browse/KUDU-3149[KUDU-3149] for more details.
> I see Alexey responded while I had a draft going. I will update with the Ji
Thank you for the update!
Once Greg asked I realized there might be other users of the Kudu C++ client in addition to impalad. I'm not sure there are many of them out there, and we haven't heard about somebody reporting the issue, but the JIRA might help to track it if somebody hits the issue.
--
To view, visit http://gerrit.cloudera.org:8080/16980
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.14.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8da030ce0f8797f8c366c56298fcda1020b00b6
Gerrit-Change-Number: 16980
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Jan 2021 03:52:14 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.14.x) Add release notes for 1.14.0
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Greg Solovyev, Bankim Bhavsar,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16980
to look at the new patch set (#3).
Change subject: Add release notes for 1.14.0
......................................................................
Add release notes for 1.14.0
Change-Id: Ib8da030ce0f8797f8c366c56298fcda1020b00b6
---
M docs/release_notes.adoc
1 file changed, 184 insertions(+), 29 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/16980/3
--
To view, visit http://gerrit.cloudera.org:8080/16980
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.14.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib8da030ce0f8797f8c366c56298fcda1020b00b6
Gerrit-Change-Number: 16980
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR](branch-1.14.x) Add release notes for 1.14.0
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16980 )
Change subject: Add release notes for 1.14.0
......................................................................
Patch Set 2:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/16980/2/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/16980/2/docs/release_notes.adoc@55
PS2, Line 55: [[rn_1.14.0_new_features]]
> A few more worth considering:
Done
http://gerrit.cloudera.org:8080/#/c/16980/2/docs/release_notes.adoc@94
PS2, Line 94: The HMS
: plugin will now check if the Kudu cluster associated with a table has HMS synchronization enabled.
> Should this be a separate bullet?
no, these are things that allow multiple clusters to be supported. I will adjust the language.
http://gerrit.cloudera.org:8080/#/c/16980/2/docs/release_notes.adoc@119
PS2, Line 119: CatalogManager
> nit: I thought we typically shied away from less user-facing names like thi
Done
http://gerrit.cloudera.org:8080/#/c/16980/2/docs/release_notes.adoc@139
PS2, Line 139: WrapSaslCall
> nit: would it make sense to not refer to specific function names and instea
Done
http://gerrit.cloudera.org:8080/#/c/16980/2/docs/release_notes.adoc@159
PS2, Line 159: maintenance manager
> nit: we should probably standardize this. "MaintenanceManager", as it is el
Done
http://gerrit.cloudera.org:8080/#/c/16980/2/docs/release_notes.adoc@174
PS2, Line 174: * Fixed a heap-use-after-free bug in Kudu C++ client that might manifest itself when altering a
> is there a Jira for this or any information on how this bug might manifest
Actually there isn't, though I am not sure if this bug was ever able to be seen by users in previous releases. I will ask Alexey to confirm. If not, we can remove the note.
https://github.com/apache/kudu/commit/ae45cd15c2703e3cfaf62aabb20ba79b961b3135
--
To view, visit http://gerrit.cloudera.org:8080/16980
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.14.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8da030ce0f8797f8c366c56298fcda1020b00b6
Gerrit-Change-Number: 16980
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Jan 2021 03:21:02 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.14.x) Add release notes for 1.14.0
Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16980 )
Change subject: Add release notes for 1.14.0
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16980/1/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/16980/1/docs/release_notes.adoc@72
PS1, Line 72: ]
extra bracket?
--
To view, visit http://gerrit.cloudera.org:8080/16980
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.14.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8da030ce0f8797f8c366c56298fcda1020b00b6
Gerrit-Change-Number: 16980
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Jan 2021 20:14:55 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.14.x) Add release notes for 1.14.0
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16980 )
Change subject: Add release notes for 1.14.0
......................................................................
Add release notes for 1.14.0
Change-Id: Ib8da030ce0f8797f8c366c56298fcda1020b00b6
Reviewed-on: http://gerrit.cloudera.org:8080/16980
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Greg Solovyev <gs...@cloudera.com>
---
M docs/release_notes.adoc
1 file changed, 185 insertions(+), 29 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
Greg Solovyev: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.cloudera.org:8080/16980
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.14.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib8da030ce0f8797f8c366c56298fcda1020b00b6
Gerrit-Change-Number: 16980
Gerrit-PatchSet: 6
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR](branch-1.14.x) Add release notes for 1.14.0
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16980 )
Change subject: Add release notes for 1.14.0
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16980/1/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/16980/1/docs/release_notes.adoc@72
PS1, Line 72: ]
> extra bracket?
Done
--
To view, visit http://gerrit.cloudera.org:8080/16980
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.14.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8da030ce0f8797f8c366c56298fcda1020b00b6
Gerrit-Change-Number: 16980
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Jan 2021 20:30:10 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.14.x) Add release notes for 1.14.0
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16980 )
Change subject: Add release notes for 1.14.0
......................................................................
Patch Set 2:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/16980/2/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/16980/2/docs/release_notes.adoc@38
PS2, Line 38: they are at or near end-of-life
> This reads as Debian is also at EOL point, but I know there is Debian 10.7
Ah, I meant to put Debian 8 explicitly.
http://gerrit.cloudera.org:8080/#/c/16980/2/docs/release_notes.adoc@71
PS2, Line 71: jars
> nit: JARs ?
Done
http://gerrit.cloudera.org:8080/#/c/16980/2/docs/release_notes.adoc@74
PS2, Line 74: Id
> nit: identifier ?
It's called an Id in many places and that is commonly used short hand for identifier. I think I would like to keep it as is.
http://gerrit.cloudera.org:8080/#/c/16980/2/docs/release_notes.adoc@119
PS2, Line 119: CatalogManager
> +1: yes, I guess "Kudu Masters" is more user-friendly.
Done
http://gerrit.cloudera.org:8080/#/c/16980/2/docs/release_notes.adoc@175
PS2, Line 175: a table
> nit: the table ?
Actually I think it's redundant.
http://gerrit.cloudera.org:8080/#/c/16980/2/docs/release_notes.adoc@185
PS2, Line 185: jars
> nit: JARs ?
Done
--
To view, visit http://gerrit.cloudera.org:8080/16980
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.14.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8da030ce0f8797f8c366c56298fcda1020b00b6
Gerrit-Change-Number: 16980
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Jan 2021 04:10:50 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.14.x) Add release notes for 1.14.0
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Greg Solovyev, Bankim Bhavsar,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16980
to look at the new patch set (#5).
Change subject: Add release notes for 1.14.0
......................................................................
Add release notes for 1.14.0
Change-Id: Ib8da030ce0f8797f8c366c56298fcda1020b00b6
---
M docs/release_notes.adoc
1 file changed, 185 insertions(+), 29 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/16980/5
--
To view, visit http://gerrit.cloudera.org:8080/16980
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.14.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib8da030ce0f8797f8c366c56298fcda1020b00b6
Gerrit-Change-Number: 16980
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR](branch-1.14.x) Add release notes for 1.14.0
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16980 )
Change subject: Add release notes for 1.14.0
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16980/2/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/16980/2/docs/release_notes.adoc@174
PS2, Line 174: * Fixed a heap-use-after-free bug in Kudu C++ client that might manifest itself when altering a
> Actually there isn't, though I am not sure if this bug was ever able to be
I see Alexey responded while I had a draft going. I will update with the Jira.
--
To view, visit http://gerrit.cloudera.org:8080/16980
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.14.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8da030ce0f8797f8c366c56298fcda1020b00b6
Gerrit-Change-Number: 16980
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Jan 2021 03:24:03 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.14.x) Add release notes for 1.14.0
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16980 )
Change subject: Add release notes for 1.14.0
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16980/2/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/16980/2/docs/release_notes.adoc@174
PS2, Line 174: * Fixed a heap-use-after-free bug in Kudu C++ client that might manifest itself when altering a
> is there a Jira for this or any information on how this bug might manifest
No, there isn't a JIRA for this, but I just filed this one a posteriori: KUDU-3238
The way how it would manifest itself varies, but bugs like this usually manifest themselves in silent data corruption and crashes with SIGSEGV, SIGBUS, or SIGABRT if hitting some sanity check down the road (the latter is reserved for lucky people with good karma :) ).
I didn't file the JIRA right away because I assumed the issue might surface in more or less the only user of the Kudu C++ client: impalad. But the latter doesn't do any DDL: in Impala, DDLs are performed only by the impala-shell, and the latter uses Kudu Java client.
--
To view, visit http://gerrit.cloudera.org:8080/16980
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.14.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8da030ce0f8797f8c366c56298fcda1020b00b6
Gerrit-Change-Number: 16980
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Jan 2021 03:13:45 +0000
Gerrit-HasComments: Yes