You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by ma...@apache.org on 2020/07/29 01:24:49 UTC

[lucene-solr] branch reference_impl_dev updated: @442 Ensure nothing runs or inits non Nightly.

This is an automated email from the ASF dual-hosted git repository.

markrmiller pushed a commit to branch reference_impl_dev
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git


The following commit(s) were added to refs/heads/reference_impl_dev by this push:
     new 4c978f1  @442 Ensure nothing runs or inits non Nightly.
4c978f1 is described below

commit 4c978f14bf1c66aed17c8df84c12e71618dc6301
Author: markrmiller@gmail.com <ma...@gmail.com>
AuthorDate: Tue Jul 28 20:23:40 2020 -0500

    @442 Ensure nothing runs or inits non Nightly.
---
 .../solr/core/backup/repository/HdfsBackupRepositoryTest.java | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/solr/core/src/test/org/apache/solr/core/backup/repository/HdfsBackupRepositoryTest.java b/solr/core/src/test/org/apache/solr/core/backup/repository/HdfsBackupRepositoryTest.java
index 3a154ca..34ec910 100644
--- a/solr/core/src/test/org/apache/solr/core/backup/repository/HdfsBackupRepositoryTest.java
+++ b/solr/core/src/test/org/apache/solr/core/backup/repository/HdfsBackupRepositoryTest.java
@@ -20,6 +20,7 @@ package org.apache.solr.core.backup.repository;
 import java.io.IOException;
 
 import org.apache.lucene.util.LuceneTestCase;
+import org.apache.solr.SolrTestCase;
 import org.apache.solr.common.util.NamedList;
 import org.apache.solr.common.util.SimpleOrderedMap;
 import org.apache.solr.core.HdfsDirectoryFactory;
@@ -29,10 +30,11 @@ import org.junit.Test;
 import static org.junit.Assert.assertEquals;
 
 @LuceneTestCase.Nightly
-public class HdfsBackupRepositoryTest {
+public class HdfsBackupRepositoryTest extends SolrTestCase {
 
   @Test(expected = NullPointerException.class)
   public void testHdfsHomePropertyMissing() throws IOException {
+    assumeTrue("Only run hdfs tests under Nightly", TEST_NIGHTLY);
     try (HdfsBackupRepository hdfsBackupRepository = new HdfsBackupRepository())  {
       NamedList<Object> namedList = new SimpleOrderedMap<>();
       hdfsBackupRepository.init(namedList);
@@ -41,6 +43,7 @@ public class HdfsBackupRepositoryTest {
 
   @Test
   public void testHdfsHomePropertySet() throws IOException {
+    assumeTrue("Only run hdfs tests under Nightly", TEST_NIGHTLY);
     try (HdfsBackupRepository hdfsBackupRepository = new HdfsBackupRepository()) {
       NamedList<Object> namedList = new SimpleOrderedMap<>();
       namedList.add(HdfsDirectoryFactory.HDFS_HOME, "hdfs://localhost");
@@ -50,6 +53,7 @@ public class HdfsBackupRepositoryTest {
 
   @Test(expected = ClassCastException.class)
   public void testCopyBufferSizeNonNumeric() throws IOException {
+    assumeTrue("Only run hdfs tests under Nightly", TEST_NIGHTLY);
     try (HdfsBackupRepository hdfsBackupRepository = new HdfsBackupRepository()) {
       NamedList<Object> namedList = new SimpleOrderedMap<>();
       namedList.add("solr.hdfs.buffer.size", "xyz");
@@ -59,6 +63,7 @@ public class HdfsBackupRepositoryTest {
 
   @Test(expected = ClassCastException.class)
   public void testCopyBufferSizeWrongType() throws IOException {
+    assumeTrue("Only run hdfs tests under Nightly", TEST_NIGHTLY);
     try (HdfsBackupRepository hdfsBackupRepository = new HdfsBackupRepository()) {
       NamedList<Object> namedList = new SimpleOrderedMap<>();
       namedList.add("solr.hdfs.buffer.size", "8192");
@@ -68,6 +73,7 @@ public class HdfsBackupRepositoryTest {
 
   @Test(expected = IllegalArgumentException.class)
   public void testCopyBufferSizeNegative() throws IOException {
+    assumeTrue("Only run hdfs tests under Nightly", TEST_NIGHTLY);
     try (HdfsBackupRepository hdfsBackupRepository = new HdfsBackupRepository()) {
       NamedList<Object> namedList = new SimpleOrderedMap<>();
       namedList.add("solr.hdfs.buffer.size", -1);
@@ -77,6 +83,7 @@ public class HdfsBackupRepositoryTest {
 
   @Test(expected = IllegalArgumentException.class)
   public void testCopyBufferSizeZero() throws IOException {
+    assumeTrue("Only run hdfs tests under Nightly", TEST_NIGHTLY);
     try (HdfsBackupRepository hdfsBackupRepository = new HdfsBackupRepository()) {
       NamedList<Object> namedList = new SimpleOrderedMap<>();
       namedList.add("solr.hdfs.buffer.size", 0);
@@ -86,6 +93,7 @@ public class HdfsBackupRepositoryTest {
 
   @Test
   public void testCopyBufferSet() throws IOException {
+    assumeTrue("Only run hdfs tests under Nightly", TEST_NIGHTLY);
     try (HdfsBackupRepository hdfsBackupRepository = new HdfsBackupRepository()) {
       NamedList<Object> namedList = new SimpleOrderedMap<>();
       namedList.add(HdfsDirectoryFactory.HDFS_HOME, "hdfs://localhost");
@@ -97,6 +105,7 @@ public class HdfsBackupRepositoryTest {
 
   @Test
   public void testCopyBufferDefaultSize() throws IOException {
+    assumeTrue("Only run hdfs tests under Nightly", TEST_NIGHTLY);
     try (HdfsBackupRepository hdfsBackupRepository = new HdfsBackupRepository()) {
       NamedList<Object> namedList = new SimpleOrderedMap<>();
       namedList.add(HdfsDirectoryFactory.HDFS_HOME, "hdfs://localhost");