You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Udo Kohlmeyer <uk...@gmail.com> on 2016/12/21 19:25:55 UTC
Review Request 54945: GEODE-419: Added test to test fail over to javax
properties if ssl enabled but relevant properties are not set
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54945/
-----------------------------------------------------------
Review request for geode, Bruce Schuchardt and Kirk Lund.
Repository: geode
Description
-------
If ssl is enabled but neither ssl-keystore or cluster-ssl-keystore properties are set, the ssl configuration behavior should be to fail over to javas properties (if provided). This seemed not to work in the previous ssl configuration implementation, but seems to be now fixed in the newer SSLConfiguration implementation.
Diffs
-----
geode-core/src/main/java/org/apache/geode/internal/net/SSLConfigurationFactory.java aa61ca36e
geode-core/src/test/java/org/apache/geode/internal/net/SSLConfigurationFactoryJUnitTest.java 38d4d87b3
Diff: https://reviews.apache.org/r/54945/diff/
Testing
-------
Added test to test scenario. No code was changed for this.
Thanks,
Udo Kohlmeyer
Re: Review Request 54945: GEODE-419: Added test to test fail over to
javax properties if ssl enabled but relevant properties are not set
Posted by Kirk Lund <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54945/#review160098
-----------------------------------------------------------
Ship it!
Add use of RestoreSystemProperties rule and then Ship It!
- Kirk Lund
On Dec. 21, 2016, 7:25 p.m., Udo Kohlmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54945/
> -----------------------------------------------------------
>
> (Updated Dec. 21, 2016, 7:25 p.m.)
>
>
> Review request for geode, Bruce Schuchardt and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> If ssl is enabled but neither ssl-keystore or cluster-ssl-keystore properties are set, the ssl configuration behavior should be to fail over to javas properties (if provided). This seemed not to work in the previous ssl configuration implementation, but seems to be now fixed in the newer SSLConfiguration implementation.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/internal/net/SSLConfigurationFactory.java aa61ca36e
> geode-core/src/test/java/org/apache/geode/internal/net/SSLConfigurationFactoryJUnitTest.java 38d4d87b3
>
> Diff: https://reviews.apache.org/r/54945/diff/
>
>
> Testing
> -------
>
> Added test to test scenario. No code was changed for this.
>
>
> Thanks,
>
> Udo Kohlmeyer
>
>
Re: Review Request 54945: GEODE-419: Added test to test fail over to
javax properties if ssl enabled but relevant properties are not set
Posted by Kirk Lund <ki...@gmail.com>.
> On Dec. 22, 2016, 6:34 p.m., Bruce Schuchardt wrote:
> > I think you should save the system properties in a @Before and restore them in an @After
Just add RestoreSystemProperties as a JUnit Rule:
@Rule
public RestoreSystemProperties restoreSystemProperties = new RestoreSystemProperties();
The Rule takes a snapshot of the system properties in before and restores them in after.
- Kirk
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54945/#review159990
-----------------------------------------------------------
On Dec. 21, 2016, 7:25 p.m., Udo Kohlmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54945/
> -----------------------------------------------------------
>
> (Updated Dec. 21, 2016, 7:25 p.m.)
>
>
> Review request for geode, Bruce Schuchardt and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> If ssl is enabled but neither ssl-keystore or cluster-ssl-keystore properties are set, the ssl configuration behavior should be to fail over to javas properties (if provided). This seemed not to work in the previous ssl configuration implementation, but seems to be now fixed in the newer SSLConfiguration implementation.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/internal/net/SSLConfigurationFactory.java aa61ca36e
> geode-core/src/test/java/org/apache/geode/internal/net/SSLConfigurationFactoryJUnitTest.java 38d4d87b3
>
> Diff: https://reviews.apache.org/r/54945/diff/
>
>
> Testing
> -------
>
> Added test to test scenario. No code was changed for this.
>
>
> Thanks,
>
> Udo Kohlmeyer
>
>
Re: Review Request 54945: GEODE-419: Added test to test fail over to
javax properties if ssl enabled but relevant properties are not set
Posted by Bruce Schuchardt <bs...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54945/#review159990
-----------------------------------------------------------
I think you should save the system properties in a @Before and restore them in an @After
- Bruce Schuchardt
On Dec. 21, 2016, 7:25 p.m., Udo Kohlmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54945/
> -----------------------------------------------------------
>
> (Updated Dec. 21, 2016, 7:25 p.m.)
>
>
> Review request for geode, Bruce Schuchardt and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> If ssl is enabled but neither ssl-keystore or cluster-ssl-keystore properties are set, the ssl configuration behavior should be to fail over to javas properties (if provided). This seemed not to work in the previous ssl configuration implementation, but seems to be now fixed in the newer SSLConfiguration implementation.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/internal/net/SSLConfigurationFactory.java aa61ca36e
> geode-core/src/test/java/org/apache/geode/internal/net/SSLConfigurationFactoryJUnitTest.java 38d4d87b3
>
> Diff: https://reviews.apache.org/r/54945/diff/
>
>
> Testing
> -------
>
> Added test to test scenario. No code was changed for this.
>
>
> Thanks,
>
> Udo Kohlmeyer
>
>