[GitHub] [incubator-superset] nytai commented on a change in pull request #11135: feat: saved query preview modal

[GitBox <gi...@apache.org>]

nytai commented on a change in pull request #11135:
URL: https://github.com/apache/incubator-superset/pull/11135#discussion_r498586156



##########
File path: superset-frontend/src/components/ListView/ListView.tsx
##########
@@ -214,6 +214,7 @@ export interface ListViewProps<T extends object = any> {
   sticky?: boolean;
   fullHeight?: boolean;
   manualSortBy?: boolean;
+  previewRowId?: number;

Review comment:
       can we rename this prop to `highlightRowId` or something that's a little less tied to the current use case? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org