You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuscany.apache.org by Raymond Feng <en...@gmail.com> on 2006/07/18 07:01:11 UTC
[PATCH] Patch for databinding was: Re: Moving chianti to trunk
Hi, Jeremy.
I have a big patch for the databinding as attached. It includes code
improvements, more transformers and test cases. Please review and apply.
Thanks,
Raymond
----- Original Message -----
From: "Jeremy Boynes" <jb...@apache.org>
To: <tu...@ws.apache.org>
Sent: Monday, July 17, 2006 8:30 PM
Subject: Moving chianti to trunk
> With the vote in favour of switching, I am about to start moving chianti
> into trunk. I will move the current sca parts into a branch
> (branches/pre-chianti) and move the chianti code into trunk. I will make
> the version in the poms 1.0-SNAPSHOT like the SDO tree.
>
> I expect to complete this tomorrow or possibly Wed if there are build
> issues. If anyone has a bunch of uncommitted changes or a big patch for
> submission please speak up soon to avoid merge issues.
>
> Thanks
> --
> Jeremy
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>
Re: [PATCH] Patch for databinding was: Re: Moving chianti to trunk
Posted by Jeremy Boynes <jb...@apache.org>.
On Jul 18, 2006, at 10:18 AM, Raymond Feng wrote:
> Hi, Jeremy.
>
> Can you try this patch? It seems that in your environment the SAX
> XMLReader may have a different feature settings on "namespaces" or
> "namespace-prefixes". With the patch, I enforce them by:
>
> reader.setFeature("http://xml.org/sax/features/namespaces",
> true); // Default to true
> reader.setFeature("http://xml.org/sax/features/namespace-prefixes",
> false); // Default to false
> Thanks,
Thanks - it works now
Patch applied.
--
Jeremy
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
Re: [PATCH] Patch for databinding was: Re: Moving chianti to trunk
Posted by Raymond Feng <en...@gmail.com>.
Hi, Jeremy.
Can you try this patch? It seems that in your environment the SAX XMLReader
may have a different feature settings on "namespaces" or
"namespace-prefixes". With the patch, I enforce them by:
reader.setFeature("http://xml.org/sax/features/namespaces", true); //
Default to true
reader.setFeature("http://xml.org/sax/features/namespace-prefixes", false);
// Default to false
Thanks,
Raymond
----- Original Message -----
From: "Jeremy Boynes" <jb...@apache.org>
To: <tu...@ws.apache.org>
Sent: Tuesday, July 18, 2006 8:59 AM
Subject: Re: [PATCH] Patch for databinding was: Re: Moving chianti to trunk
> On Jul 18, 2006, at 8:46 AM, Raymond Feng wrote:
>
>> Hi,
>>
>> I ran into this issue once inside Eclipse but cannot reproduce it any
>> more. It's probably related to some settings of the SAX/DOM features on
>> namespace handling. I'll investigate.
>>
>> What JDK do you use? I tried IBM and SUN JDKs and both are fine.
>
> $ java -version
> java version "1.5.0_06"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_06-112)
> Java HotSpot(TM) Client VM (build 1.5.0_06-64, mixed mode, sharing)
>
> on OSX 10.4.7
> --
> Jeremy
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>
Re: [PATCH] Patch for databinding was: Re: Moving chianti to trunk
Posted by Jeremy Boynes <jb...@apache.org>.
On Jul 18, 2006, at 8:46 AM, Raymond Feng wrote:
> Hi,
>
> I ran into this issue once inside Eclipse but cannot reproduce it
> any more. It's probably related to some settings of the SAX/DOM
> features on namespace handling. I'll investigate.
>
> What JDK do you use? I tried IBM and SUN JDKs and both are fine.
$ java -version
java version "1.5.0_06"
Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_06-112)
Java HotSpot(TM) Client VM (build 1.5.0_06-64, mixed mode, sharing)
on OSX 10.4.7
--
Jeremy
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
Re: [PATCH] Patch for databinding was: Re: Moving chianti to trunk
Posted by Raymond Feng <en...@gmail.com>.
Hi,
I ran into this issue once inside Eclipse but cannot reproduce it any more.
It's probably related to some settings of the SAX/DOM features on namespace
handling. I'll investigate.
What JDK do you use? I tried IBM and SUN JDKs and both are fine.
Thanks,
Raymond
----- Original Message -----
From: "Jeremy Boynes" <jb...@apache.org>
To: <tu...@ws.apache.org>
Sent: Tuesday, July 18, 2006 6:37 AM
Subject: Re: [PATCH] Patch for databinding was: Re: Moving chianti to trunk
> On Jul 17, 2006, at 11:12 PM, Raymond Feng wrote:
>
>> Hi,
>>
>> I can run the all the test cases successfully using "mvn clean install".
>> Can you post me the stacktrace?
>
> I commented out the test bodies. If I uncomment them I get:
>
> Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.061 sec
> <<< FAILURE!
> testTransform1 (org.apache.tuscany.databinding.impl.MediatorImplTestCase)
> Time elapsed: 0.033 sec <<< ERROR!
> org.apache.tuscany.databinding.TransformationException:
> org.w3c.dom.DOMException: NAMESPACE_ERR: An attempt is made to create or
> change an object in a way which is incorrect with regard to namespaces.
> at org.apache.tuscany.databinding.trax.String2SAX.transform
> (String2SAX.java:47)
> at org.apache.tuscany.databinding.trax.String2SAX.transform
> (String2SAX.java:36)
> at org.apache.tuscany.databinding.impl.MediatorImpl.mediate
> (MediatorImpl.java:62)
> at
> org.apache.tuscany.databinding.impl.MediatorImplTestCase.testTransform1(
> MediatorImplTestCase.java:70)
>
> testTransform2 (org.apache.tuscany.databinding.impl.MediatorImplTestCase)
> Time elapsed: 0.006 sec <<< ERROR!
> org.apache.tuscany.databinding.TransformationException:
> org.w3c.dom.DOMException: NAMESPACE_ERR: An attempt is made to create or
> change an object in a way which is incorrect with regard to namespaces.
> at org.apache.tuscany.databinding.trax.String2SAX.transform
> (String2SAX.java:47)
> at org.apache.tuscany.databinding.trax.String2SAX.transform
> (String2SAX.java:36)
> at org.apache.tuscany.databinding.impl.MediatorImpl.mediate
> (MediatorImpl.java:82)
> at
> org.apache.tuscany.databinding.impl.MediatorImplTestCase.testTransform2(
> MediatorImplTestCase.java:79)
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
Re: [PATCH] Patch for databinding was: Re: Moving chianti to trunk
Posted by Jeremy Boynes <jb...@apache.org>.
On Jul 17, 2006, at 11:12 PM, Raymond Feng wrote:
> Hi,
>
> I can run the all the test cases successfully using "mvn clean
> install". Can you post me the stacktrace?
I commented out the test bodies. If I uncomment them I get:
Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.061
sec <<< FAILURE!
testTransform1
(org.apache.tuscany.databinding.impl.MediatorImplTestCase) Time
elapsed: 0.033 sec <<< ERROR!
org.apache.tuscany.databinding.TransformationException:
org.w3c.dom.DOMException: NAMESPACE_ERR: An attempt is made to create
or change an object in a way which is incorrect with regard to
namespaces.
at org.apache.tuscany.databinding.trax.String2SAX.transform
(String2SAX.java:47)
at org.apache.tuscany.databinding.trax.String2SAX.transform
(String2SAX.java:36)
at org.apache.tuscany.databinding.impl.MediatorImpl.mediate
(MediatorImpl.java:62)
at
org.apache.tuscany.databinding.impl.MediatorImplTestCase.testTransform1(
MediatorImplTestCase.java:70)
testTransform2
(org.apache.tuscany.databinding.impl.MediatorImplTestCase) Time
elapsed: 0.006 sec <<< ERROR!
org.apache.tuscany.databinding.TransformationException:
org.w3c.dom.DOMException: NAMESPACE_ERR: An attempt is made to create
or change an object in a way which is incorrect with regard to
namespaces.
at org.apache.tuscany.databinding.trax.String2SAX.transform
(String2SAX.java:47)
at org.apache.tuscany.databinding.trax.String2SAX.transform
(String2SAX.java:36)
at org.apache.tuscany.databinding.impl.MediatorImpl.mediate
(MediatorImpl.java:82)
at
org.apache.tuscany.databinding.impl.MediatorImplTestCase.testTransform2(
MediatorImplTestCase.java:79)
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
Re: [PATCH] Patch for databinding was: Re: Moving chianti to trunk
Posted by Raymond Feng <en...@gmail.com>.
Hi,
I can run the all the test cases successfully using "mvn clean install". Can
you post me the stacktrace?
The patch includes the following:
1) Refactor the transformer interfaces to have PullTransformer,
PushTransformer and DataPipe extend from Transformer
2) Add cache to shortest path to the graph
3) Add annotations for databinding
4) Add more transformer implementations
5) Improve Mediator interface and implementation (spinned off from
TransformerRegistryImpl) (To be integrated as a system service).
6) Add more test casses
Thanks,
Raymond
----- Original Message -----
From: "Jeremy Boynes" <jb...@apache.org>
To: <tu...@ws.apache.org>
Sent: Monday, July 17, 2006 10:49 PM
Subject: Re: [PATCH] Patch for databinding was: Re: Moving chianti to trunk
>
> On Jul 17, 2006, at 10:01 PM, Raymond Feng wrote:
>
>> Hi, Jeremy.
>>
>> I have a big patch for the databinding as attached. It includes code
>> improvements, more transformers and test cases. Please review and apply.
>
> I applied this but it is a big large to review easily - can you break
> down what is going on in there?
>
> I did have a problem with MediatorTestCase failing but rather than hold
> off I commented out the tests. Please can you have a look at those and
> get them working again.
>
> Thanks
> Jeremy
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
Re: [PATCH] Patch for databinding was: Re: Moving chianti to trunk
Posted by Jeremy Boynes <jb...@apache.org>.
On Jul 17, 2006, at 10:01 PM, Raymond Feng wrote:
> Hi, Jeremy.
>
> I have a big patch for the databinding as attached. It includes
> code improvements, more transformers and test cases. Please review
> and apply.
I applied this but it is a big large to review easily - can you break
down what is going on in there?
I did have a problem with MediatorTestCase failing but rather than
hold off I commented out the tests. Please can you have a look at
those and get them working again.
Thanks
Jeremy
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org