Re: [PR] feat(writer): Make LocationGenerator partition-aware [iceberg-rust]

["CTTY (via GitHub)" <gi...@apache.org>]

CTTY commented on code in PR #1625:
URL: https://github.com/apache/iceberg-rust/pull/1625#discussion_r2314794274


##########
crates/iceberg/src/writer/file_writer/location_generator.rs:
##########
@@ -136,8 +159,17 @@ pub(crate) mod test {
     }
 
     impl LocationGenerator for MockLocationGenerator {
-        fn generate_location(&self, file_name: &str) -> String {
-            format!("{}/{}", self.root, file_name)
+        fn generate_location(&self, partition: Option<&PartitionKey>, file_name: &str) -> String {

Review Comment:
   I had the same thought as well, not sure why we even need a mock location gen. let me give it a try



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org