[GitHub] [pulsar] eolivelli commented on a change in pull request #11322: Pulsar IO: allow Sinks to use native AVRO and JSON

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #11322:
URL: https://github.com/apache/pulsar/pull/11322#discussion_r671258381



##########
File path: pulsar-functions/runtime-all/src/test/java/org/apache/pulsar/functions/instance/JavaInstanceDepsTest.java
##########
@@ -60,11 +60,14 @@ public void testInstanceJarDeps() throws IOException {
             if (e == null)
                 break;
             String name = e.getName();
-            if (name.endsWith(".class") && !name.startsWith("META-INF")) {
+            if (name.endsWith(".class") && !name.startsWith("META-INF") && !name.equals("module-info.class")) {
                 // The only classes in the java-instance.jar should be org.apache.pulsar, slf4j, and log4j classes

Review comment:
       done, thanks




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org