You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Vinay (JIRA)" <ji...@apache.org> on 2014/02/07 13:47:24 UTC
[jira] [Updated] (HDFS-5903) FSVolumeList#initializeReplicaMaps(..)
not doing anything, it can be removed
[ https://issues.apache.org/jira/browse/HDFS-5903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vinay updated HDFS-5903:
------------------------
Attachment: HDFS-5903.patch
Attaching a patch
Please review
> FSVolumeList#initializeReplicaMaps(..) not doing anything, it can be removed
> ----------------------------------------------------------------------------
>
> Key: HDFS-5903
> URL: https://issues.apache.org/jira/browse/HDFS-5903
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode
> Reporter: Vinay
> Assignee: Vinay
> Priority: Minor
> Attachments: HDFS-5903.patch
>
>
> {code} void initializeReplicaMaps(ReplicaMap globalReplicaMap) throws IOException {
> for (FsVolumeImpl v : volumes) {
> v.getVolumeMap(globalReplicaMap);
> }
> }{code}
> This method has been called at the time of initialization even before the blockpools are added. So its useless to call this method.
> Anyway replica map will be updated for each of the blockpool during {{addBlockPool(..)}} by calling {{FSVolumesList#getAllVolumesMap(..)}}
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)