You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/06/10 15:19:02 UTC

[GitHub] [flink] azagrebin opened a new pull request #12590: [FLINK-18214][Runtime] Remove Job Cache size check against JVM Heap size

azagrebin opened a new pull request #12590:
URL: https://github.com/apache/flink/pull/12590


   Checking that the job cache size is less than JVM heap for JM, may be inconclusive and confusing for users. The job cache size option does not strictly limit the real size and stays an advanced emergency mean. The job size calculation is approximate and the real cache size can be larger than its configured limit (`jobstore.cache-size`).
   
   Therefore, this PR removes the related code from `JobManagerFlinkMemoryUtils`, tests and memory tuning guide.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12590: [FLINK-18214][Runtime] Remove Job Cache size check against JVM Heap size

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12590:
URL: https://github.com/apache/flink/pull/12590#issuecomment-642093792


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4eb35c425965ed97954a73aa99174d1a08c9daad",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4eb35c425965ed97954a73aa99174d1a08c9daad",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4eb35c425965ed97954a73aa99174d1a08c9daad UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] azagrebin closed pull request #12590: [FLINK-18214][Runtime] Remove Job Cache size check against JVM Heap size

Posted by GitBox <gi...@apache.org>.
azagrebin closed pull request #12590:
URL: https://github.com/apache/flink/pull/12590


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12590: [FLINK-18214][Runtime] Remove Job Cache size check against JVM Heap size

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12590:
URL: https://github.com/apache/flink/pull/12590#issuecomment-642093792


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4eb35c425965ed97954a73aa99174d1a08c9daad",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3205",
       "triggerID" : "4eb35c425965ed97954a73aa99174d1a08c9daad",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4eb35c425965ed97954a73aa99174d1a08c9daad Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3205) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12590: [FLINK-18214][Runtime] Remove Job Cache size check against JVM Heap size

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12590:
URL: https://github.com/apache/flink/pull/12590#issuecomment-642093792


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4eb35c425965ed97954a73aa99174d1a08c9daad",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3205",
       "triggerID" : "4eb35c425965ed97954a73aa99174d1a08c9daad",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4eb35c425965ed97954a73aa99174d1a08c9daad Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3205) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12590: [FLINK-18214][Runtime] Remove Job Cache size check against JVM Heap size

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12590:
URL: https://github.com/apache/flink/pull/12590#issuecomment-642080490


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 4eb35c425965ed97954a73aa99174d1a08c9daad (Wed Jun 10 15:22:09 UTC 2020)
   
    ✅no warnings
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] azagrebin commented on pull request #12590: [FLINK-18214][Runtime] Remove Job Cache size check against JVM Heap size

Posted by GitBox <gi...@apache.org>.
azagrebin commented on pull request #12590:
URL: https://github.com/apache/flink/pull/12590#issuecomment-642461817


   Thanks for the review @zentol 
   The failure is known by FLINK-16821 and unrelated, merging this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org